Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 493126

Summary:	Style handling inconsistent in Zest
Product:	[Tools] GEF	Reporter:	Tamas Miklossy <miklossy>
Component:	GEF Zest	Assignee:	Alexander Nyßen <nyssen>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	nyssen
Version:	unspecified
Target Milestone:	4.0.0 (Neon) RC1
Hardware:	PC
OS:	Windows 7
Whiteboard:
Bug Depends on:
Bug Blocks:	493115

Description Tamas Miklossy

2016-05-06 05:53:38 EDT

The following Zest properties are missing from the ZestProperties class to be consistent with the other Zest properties handling:
- Source Label Css Style
- Target Label Cs Style
- Source Decoration Css Style
- Target Decoration Css Style

Apart from that, the org.eclipse.gef4.fx.nodes.Connection class contains the private static final String CSS_CLASS_DECORATION = "decoration"; variable declaration. This variable declaration should be moved to Zest.

Comment 1 Alexander Nyßen

2016-05-06 06:32:38 EDT

I pushed the following changes to origin/master:

- Ensure Connection does not expose decoration CSS class, as this is a Zest concept. Moved the respective definition to EdgePart.
- Ensured EdgePart properly updates the css classes of the curve node and the decoration nodes (which may all be exchanged).
- Ensured that NodePart properly updates the css class of the shape node (which may be exchanged).
- Added Zest properties for source and target decoration css styles.
- Ensure EdgePart updates source and target decorations with the provided styles (from ZestProperties).
- Added support to ZestProperties for getting and setting source and target label css styles.
- Ensure EdgeLabelPart properly applies the respective label css styles.

Resolving as fixed in 4.0.0 RC1.