Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 493065

Summary:	Node shape is always sized to enclose label, even is fixedsize is true and smaller size is specified.
Product:	[Tools] GEF	Reporter:	Alexander Nyßen <nyssen>
Component:	GEF DOT	Assignee:	Alexander Nyßen <nyssen>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3
Version:	0.2.0
Target Milestone:	4.0.0 (Neon) RC1
Hardware:	All
OS:	All
Whiteboard:

Description Alexander Nyßen

2016-05-05 07:21:05 EDT

The shape of a Node is always sized to enclose the label (as its size is bound to the size of the container. Instead, if fixedsize is specified, it should use the specified size, not the computed one. That is, within zest, we have to ensure that the shape is resized to the size specified within the Zest attributes.

Comment 1 Alexander Nyßen

2016-05-05 08:09:54 EDT

When fixedsize is given and the label does not fit, we need to place it horizontally centered.

Comment 2 Alexander Nyßen

2016-05-05 13:31:21 EDT

I pushed the following changes to origin/master:

- Ensured that FXResizePolicy respects the the specified min size of Region nodes as well as the computed min size for resizable nodes.
- Added setters and getters for max, min, and preferred size to GeometryNode, as well as related writable Double properties, so these can be properly set (if they always used the pref size, resizing beyond their current layout bounds would not be possible).
- Ensured NodePart shape is resized to fit the value of ZestProperties.getSize().
- Ensured the NodePart visual (group) specifies reasonable max and min values (based on the contained vbox), so it can be properly resized.
- Ensured NodePart shape is relocated to be centered with respect to the underlying vbox.
- Ensured hbox (and thus also the label) is vertically centered.

Resolving as fixed in 4.0.0 RC1.