Bugzilla – Full Text Bug Listing
| Summary: | Duplicate commands / menu items "Toggle Full Screen" | ||
|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Markus Keller <markus.kell.r> |
| Component: | UI | Assignee: | Brian de Alwis <bsd> |
| Status: | VERIFIED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | bsd, daniel_megert, Lars.Vogel, markus.kell.r, psuzzi |
| Version: | 4.6 | Flags: | psuzzi:
review+
Lars.Vogel: review+ |
| Target Milestone: | 4.6 RC2 | ||
| Hardware: | PC | ||
| OS: | Mac OS X | ||
| See Also: |
https://git.eclipse.org/r/72445 https://git.eclipse.org/r/72979 https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=8c5781af7c90ae6f6baa91495a2ac0ca0f1dd907 https://bugs.eclipse.org/bugs/show_bug.cgi?id=493930 https://bugs.eclipse.org/bugs/show_bug.cgi?id=493932 |
||
| Whiteboard: | |||
| Bug Depends on: | 491572 | ||
| Bug Blocks: | |||
|
Description
Markus Keller
I cannot reproduce the issue with Windows 10 and Neon (4.6) Build id: I20160427-0400 http://i.imgur.com/kokYTch.png Brian, could you reproduce this? It's mac-specific: we have a Cocoa fragment that contributes items that needs to be updated. So the standard on OS X seems to have become "Enter Full Screen" and it appears under a "View" menu, which we don't have. So I'm happy to remove the item entirely from "Window" and just use the variant under Window > Appearance. New Gerrit change created: https://git.eclipse.org/r/72445 I've pushed work-in-progress that: - Removes Window > Toggle Full Screen for Cocoa - Adds keybinding for new org.eclipse.ui.window.fullscreenmode - Add deprecation warning to old org.eclipse.e4.ui.workbench.renderers.swt.cocoa.FullscreenWindowHandler Since the current OSX-specific code has been in place since 4.2, I think we can only deprecate it and remove the org.eclipse.ui.cocoa.fullscreenWindow command in 4.7. And since it was done in the E4 level, whereas the current fullscreen implementation is at the E3.x level, we still need to install a keybinding for potential E4 apps. Hmm, I think the better approach is to move the now-deprecated style into an after-addon, that will be run after the E3.x BindingServiceAddon has started operation. Then we can see if we have a new-style command or whether we're running as a pure E4 app. I've been experimenting with the new full-screen handler. The new popup dialog leads to a poor animation experience on OS X as: 1. the full-screen window flashes up in the background 2. then the original window animates to expand full-screen 3. and then the popup dialog is shown. The animation is good once the popup dialog is set to never show again. As we've had this full-screen functionality on OS X since 4.2, for RC2 I think we should: 1. ensure the new org.eclipse.ui.window.fullscreenmode menu items don't show on Cocoa 2. mark the old org.eclipse.ui.cocoa.fullscreenWindow command as deprecated for 4.6, to be removed in 4.7 New Gerrit change created: https://git.eclipse.org/r/72979 Can't test this on Mac but change looks reasonable. Reviewed on Mac, works as expected. Gerrit change https://git.eclipse.org/r/72979 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=8c5781af7c90ae6f6baa91495a2ac0ca0f1dd907 Fixed for RC2. Will file separate bugs to deprecate org.eclipse.ui.cocoa.fullscreenWindow for RC3 and removal in 4.7. Verified no duplicates in 4.6.0.I20160519-1730. |
