| Summary: | Publish org.eclipse.rap.nebula.jface.gridviewer and org.eclipse.rap.nebula.widgets.grid in maven central repository | ||
|---|---|---|---|
| Product: | [RT] RAP | Reporter: | Sebastian Habenicht <dev> |
| Component: | Releng | Assignee: | Project Inbox <rap-inbox> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | mknauer |
| Version: | 3.0 | ||
| Target Milestone: | 3.1 RC1 | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
|
Description
Sebastian Habenicht
I added the new bundles as part of the submission of our first release candidate RAP 3.1.0 RC1. Sebastian, would it be possible for you to check the following temporary/staging Maven repository before I release the bundles to Maven Central? That would be great! https://oss.sonatype.org/content/repositories/orgeclipserap-1049 Creating a GridViewer using the grid dependencies from that repository succeeded. (I only had to change the jface and rwt dependencies in the poms from 3.1.0 to 3.1.0-M7 and the grid dependency from 3.1.0 to 3.1.0-RC1, since 3.1.0 is not available on central yet.) Thanks for uploading! One other thing: In the related forum thread, Ivan already said that adding cell selection to RAP's nebula grid means a lot of changes and cannot be done for 3.1; I wonder if this great feature is on the roadmap for 3.2 - shall I open a bugzilla for this feature request, if it's not? Hi Sebastian, I didn't find any enhancement request in bugzilla about cell selection in Grid. Please file one to keep the discussion/planning there. (In reply to Sebastian Habenicht from comment #2) > Creating a GridViewer using the grid dependencies from that repository > succeeded. Thanks for testing! (In reply to Sebastian Habenicht from comment #2) > (I only had to change the jface and rwt dependencies in the poms > from 3.1.0 to 3.1.0-M7 and the grid dependency from 3.1.0 to 3.1.0-RC1, > since 3.1.0 is not available on central yet.) You had to change the dependency manually? I was under the impression that a soft version requirement like the following on org.eclipse.rap.nebula.widgets.grid <dependency> <groupId>org.eclipse.rap</groupId> <artifactId>org.eclipse.rap.rwt</artifactId> <version>3.1.0</version> </dependency> would resolve with a version 3.1.0-FOOBAR, 3.1.0-RC1, or even 3.1.0-M7 from Maven Central. Did I miss something? Ivan: I opened 494517 (which you already noticed, sorry for setting the wrong meta tags). Markus: I am from being a maven expert, so I had to look things up on the internet: As far as I understood from here [1], soft version requirement refers to *bare* version numbers, meaning that the dependency with the later version will be used (e.g. 1.5 instead of 1.2) if both versions are defined in the dependency tree. So this concept does not seem to apply to version numbers with qualifiers, such as 3.1.0-M7. But even if it would, it would not work, because - as stated here [2] - "All versions with a qualifier are older than the same version without a qualifier (release version)". Thus, when I declare 3.1.0 as required dependency and it does not exist yet, maven will not take 3.1.0-M7 instead, since 3.1.0-M7 is older than the required dependency 3.1.0 (and might not include specific features I depend on). Only exception is the SNAPSHOT qualifier (see [2]). Again, no expert, so I cannot verify that the mentioned sources or my conclusion are correct. [1] https://books.google.de/books?id=4aWSAwAAQBAJ&lpg=PA344&ots=bARWSYmXKJ&dq=maven%20%22soft%20version%20requirement%22&pg=PA344#v=onepage&q=maven%20%22soft%20version%20requirement%22&f=false [2] https://docs.oracle.com/middleware/1212/core/MAVEN/maven_version.htm#MAVEN400 That makes sense... I'm just a bit puzzled that no one else complained so far. I dropped the old staging repo from comment #1, and uploaded a new staging repo with updated dependency information: https://oss.sonatype.org/content/repositories/orgeclipserap-1050/ In this repository the RAP-internal dependencies are using the full version, i.e. "3.1.0-RC1" instead of just "3.1.0". If you have some time it would be good if you could give this another test-run. I will publish it tomorrow (Thursday). (As an additional plus I took the freedom of uploading the RC2 bits that will be released on Friday, currently available from this temporary staging repo URL: https://oss.sonatype.org/content/repositories/orgeclipserap-1051) Tested grid and file dialog with 3.1.0-RC1 and 3.1.0-RC2 successfully, using the respective repositories. Thanks for adjusting the version number structure! My guess is that almost everyone builds RAP applications and therefore uses plugin dependency management with target platforms. But when it comes to RWT web applications, maven dependency management imo is much more easier and more flexible than providing the correct target platform on the build server and in my IDE. Much thanks for testing! 3.1.0-RC1 has now arrived in Maven Central (see e.g. [1]), closing this bug as fixed. [1] http://search.maven.org/#artifactdetails|org.eclipse.rap|org.eclipse.rap.rwt|3.1.0-RC1|jar |