Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 492312

Summary: [HiDPI][Win] no icons seen on Horizontal toolbars with Neon M7 using custom DPI settings like 168/166/175
Product: [Eclipse Project] Platform Reporter: Lorenzo Bettini <lorenzo.bettini>
Component: SWTAssignee: Niraj Modi <niraj.modi>
Status: RESOLVED WORKSFORME QA Contact:
Severity: normal    
Priority: P3 CC: arunkumar.thondapu, dejan2609, dirk.fauth, kesselhaus, kwachter88, loskutov, lshanmug, niraj.modi, peter
Version: 4.6   
Target Milestone: ---   
Hardware: PC   
OS: Windows All   
Whiteboard:
Bug Depends on: 493462    
Bug Blocks: 493723    
Attachments:
Description Flags
screenshot showing the problem
none
168DPI_Win7_No_Icons_In_Toolbar
none
Icons on Eclipse Neon M6 and latest integration build
none
icons appear only on vertical toolbars
none
latest Neon integration build: all icons are fine none

Description Lorenzo Bettini CLA 2016-04-24 04:15:25 EDT
Created attachment 261198 [details]
screenshot showing the problem

I just tries the integration build I20160419-0800 and in Windows 8, with HIDPI, and scale factor the icons on the toolbar are not shown at all (see the attached screenshot)
Comment 1 Andrey Loskutov CLA 2016-04-24 04:40:18 EDT
Which resolution / scaling factor do you have?
Comment 2 Lorenzo Bettini CLA 2016-04-24 11:02:48 EDT
(In reply to Andrey Loskutov from comment #1)
> Which resolution / scaling factor do you have?

Resolution 3200×1800 scaling 200%
Comment 3 Lorenzo Bettini CLA 2016-05-03 07:09:22 EDT
Problem still present in I20160502-2000
Comment 4 Niraj Modi CLA 2016-05-05 04:35:59 EDT
This issue not reproducible on Win7 200% zoom.
Since the images are properly scaled in most of the placed and looks like a problem with Toolbar widget only @ Win8/200% zoom.

Work-around here is to disable the HighDPI Feature as below:
You can use -Dswt.enable.autoScale=false in eclipse.ini or at commandline
Comment 5 Niraj Modi CLA 2016-05-09 04:53:36 EDT
*** Bug 493197 has been marked as a duplicate of this bug. ***
Comment 6 Arun Thondapu CLA 2016-05-10 05:27:56 EDT
*** Bug 493288 has been marked as a duplicate of this bug. ***
Comment 7 Dirk Fauth CLA 2016-05-10 06:14:55 EDT
I have the same issue on Windows 10. I have set the scaling to 175%. Note that you need to log off and on to see that.
Comment 8 Niraj Modi CLA 2016-05-10 08:21:18 EDT
Created attachment 261593 [details]
168DPI_Win7_No_Icons_In_Toolbar

(In reply to Arun Thondapu from comment #6)
> *** Bug 493288 has been marked as a duplicate of this bug. ***

(In reply to Dirk Fauth from comment #7)
> I have the same issue on Windows 10. I have set the scaling to 175%. Note
> that you need to log off and on to see that.

We are able to reproduce this issue on Win7 as well at 168% DPI settings.

Interesting part: Issue is seen with Horizontal Toolbar only and not with vertical toolbar. Refer attachment.
Comment 9 Dejan Stojadinović CLA 2016-05-12 08:00:55 EDT
My configuration:
* Windows 10, 64 bit
* resolution: 3840 x 2160 (recommended)
* scaling: 250% (recommended)
* I stay away from hacking via registry key and/or external manifest

Results: 
* Neon M6 worked like a charm
* Neon M7 and latest integration builds: icons are not visible

See attached file for more details.
Comment 10 Dejan Stojadinović CLA 2016-05-12 08:02:15 EDT
Created attachment 261681 [details]
Icons on Eclipse Neon M6 and latest integration build
Comment 11 Dejan Stojadinović CLA 2016-05-12 10:38:04 EDT
Created attachment 261693 [details]
icons appear only on vertical toolbars

As stated above by Niraj Modi: icons appear only on vertical toolbars.
Comment 12 Lakshmi P Shanmugam CLA 2016-05-13 02:46:00 EDT
Can you try with the latest I-build (I20160512-1000)? This problem should be fixed since eclipse now uses integer scaling by default (Bug 493462).
Comment 13 Niraj Modi CLA 2016-05-13 05:05:20 EDT
(In reply to Lakshmi Shanmugam from comment #12)
> Can you try with the latest I-build (I20160512-1000)? This problem should be
> fixed since eclipse now uses integer scaling by default (Bug 493462).

This issue not seen any more with fix for bug 493462, in latest I-Build on Win7:
I20160512-1000

Just summarizing the behavior with integer scaling:
For OS DPI value < 175, is treated as 100% by Eclipse
For OS DPI value >= 175, is treated as 200% by Eclipse
Comment 14 Dejan Stojadinović CLA 2016-05-13 05:44:11 EDT
Created attachment 261714 [details]
latest Neon integration build: all icons are fine
Comment 15 Arun Thondapu CLA 2016-05-13 06:13:20 EDT
(In reply to Niraj Modi from comment #13)
> (In reply to Lakshmi Shanmugam from comment #12)
> > Can you try with the latest I-build (I20160512-1000)? This problem should be
> > fixed since eclipse now uses integer scaling by default (Bug 493462).
> 
> This issue not seen any more with fix for bug 493462, in latest I-Build on
> Win7:
> I20160512-1000

Niraj, should we keep the bug open for fixing the probable root cause of this issue? The problem would still occur if we use exact or quarter for setting the -Dswt.autoScale property, isn't it?
Comment 16 Noopur Gupta CLA 2016-05-16 03:17:37 EDT
*** Bug 493702 has been marked as a duplicate of this bug. ***
Comment 17 Niraj Modi CLA 2016-05-16 03:32:37 EDT
(In reply to Arun Thondapu from comment #15)
> (In reply to Niraj Modi from comment #13)
> > (In reply to Lakshmi Shanmugam from comment #12)
> > > Can you try with the latest I-build (I20160512-1000)? This problem should be
> > > fixed since eclipse now uses integer scaling by default (Bug 493462).
> > 
> > This issue not seen any more with fix for bug 493462, in latest I-Build on
> > Win7:
> > I20160512-1000
> 
> Niraj, should we keep the bug open for fixing the probable root cause of
> this issue? The problem would still occur if we use exact or quarter for
> setting the -Dswt.autoScale property, isn't it?

For custom DPI settings, I have logged a separate bug 493723.