Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 492243

Summary:	Useless expression in inlineSearchResultExplorer.js
Product:	[ECD] Orion	Reporter:	Max Schaefer <max>
Component:	Client	Assignee:	Grant Gayed <grant_gayed>
Status:	RESOLVED FIXED	QA Contact:
Severity:	minor
Priority:	P3	CC:	Michael_Rennie
Version:	unspecified
Target Milestone:	12.0
Hardware:	PC
OS:	Linux
Whiteboard:

Description Max Schaefer

2016-04-22 07:19:56 EDT

Consider line 213 of bundles/org.eclipse.orion.client.ui/web/orion/inlineSearchResultExplorer.js (https://github.com/eclipse/orion.client/blob/82ff15a54ee581c6b306bbc84ad2baa197434a54/bundles/org.eclipse.orion.client.ui/web/orion/inlineSearchResultExplorer.js#L213):

  item.parent.location ? item.parent.location : '#';

Surely the result of this expression should be assigned to some variable? Perhaps 'loc'?

Comment 1 Grant Gayed

2016-04-26 17:47:42 EDT

Based on what was in before commit http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/diff/bundles/org.eclipse.orion.client.ui/web/orion/inlineSearchResultExplorer.js?id=e822a603701fc63883ee21d54317dc4c1f729690 I'd say yes.  Mike if this seems wrong then please follow up.

Fixed, commit: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=66b658bc515832e8025c102162a3f38567e618d9 .  Thanks again Max.