Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 492240

Summary: Misbracketed condition in thirdPartyNLSPlugin/orion/plugin.js
Product: [ECD] Orion Reporter: Max Schaefer <max>
Component: ClientAssignee: Grant Gayed <grant_gayed>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3    
Version: unspecified   
Target Milestone: 12.0   
Hardware: PC   
OS: Linux   
Whiteboard:

Description Max Schaefer CLA 2016-04-22 06:57:27 EDT 
On line 242 of bundles/org.eclipse.orion.client.ui/web/plugins/samples/thirdPartyNLSPlugin/orion/plugin.js (https://github.com/eclipse/orion.client/blob/82ff15a54ee581c6b306bbc84ad2baa197434a54/bundles/org.eclipse.orion.client.ui/web/plugins/samples/thirdPartyNLSPlugin/orion/plugin.js#L242):

  if (!method in object) {
    ...
  }

Note that "!" binds tighter than "in", so this check never succeeds (well, unless "object" has members named "true" or "false"). No doubt this should be

  if (!(method in object)) {
    ...
  }