Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 492003

Summary: Under certain conditions, pressing the Escape key during a direct label edit leads to unexpected behavior
Product: [Modeling] Sirius Reporter: Daria Tioc-Deac <daria.tioc-deac>
Component: DiagramAssignee: Pierre-Charles David <pierre-charles.david>
Status: CLOSED FIXED QA Contact: Florian Barbin <florian.barbin>
Severity: minor    
Priority: P3 CC: daria.tioc-deac, florian.barbin, laurent.redor, niels.brouwers, pierre-charles.david
Version: 3.1.0Keywords: triaged
Target Milestone: 4.0.0M7   
Hardware: PC   
OS: Windows 8   
See Also: https://git.eclipse.org/r/70965
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=7bf8c4745cb73404950e20ee6c97ad67688b019d
Whiteboard:
Attachments:
Description Flags
basicfamily proj
none
edit label screenshot none

Description Daria Tioc-Deac CLA 2016-04-19 09:37:56 EDT
Created attachment 261084 [details]
basicfamily proj

Steps to reproduce:
1. Connect two nodes with an edge that does not display a label. 
2. Zoom in on the diagram (125% or 150% is sufficient; the problem does not occur when the diagram is not zoomed in).
2. Select the edge and press F2 to launch direct label edit. Press the Escape key. The edit crashes leaving behind the border of the edit label box. In this state, left-clicking no longer works to change the selection, F2 also does not open the edit label box again.

I attached a simple project based on the basicfamily Sirius sample that can be used to reproduce the issue.
Comment 1 Daria Tioc-Deac CLA 2016-04-19 09:39:09 EDT
Created attachment 261085 [details]
edit label screenshot
Comment 2 Eclipse Genie CLA 2016-04-19 10:29:38 EDT
New Gerrit change created: https://git.eclipse.org/r/70965
Comment 3 Pierre-Charles David CLA 2016-04-19 10:32:51 EDT
Thanks for the detailed bug report!

I've reproduced it and at first glance at least it looks like a basic error. I've pushed a patch for a possible fix for review at https://git.eclipse.org/r/70965. If the review confirms there is nothing more to it than that (no hidden impact or more complex root cause), it may be included in the next version (4.0 for Ecipse Neon).
Comment 5 Pierre-Charles David CLA 2016-04-21 03:30:59 EDT
Fixed by 7bf8c4745cb73404950e20ee6c97ad67688b019d.
Comment 6 Florian Barbin CLA 2016-05-25 04:41:01 EDT
Verified on Sirius 4.0.0.RC1
Comment 7 Pierre-Charles David CLA 2016-06-24 07:59:30 EDT
Available in Sirius 4.0.0.