Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 491932

Summary: Server test failures on Mac
Product: [ECD] Orion Reporter: Michael Rennie <Michael_Rennie>
Component: NodeAssignee: Silenio Quarti <Silenio_Quarti>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: Silenio_Quarti
Version: 12.0   
Target Milestone: ---   
Hardware: PC   
OS: Mac OS X   
Whiteboard:

Description Michael Rennie CLA 2016-04-18 12:55:21 EDT
Running the tests locally on Mac (might also fail on other platforms, didn't test yet), you get the following failure:

1) prefs when prefs.json exists and we DELETE a non-existent node should have no effect:

      AssertionError: expected { user: { foo2: false }, zzz: 1 } to deeply equal { Object (user, zzz) }
      + expected - actual

       {
         "user": {
      +    "foo": {
      +      "bar": 123
      +      "qux": "q"
      +    }
           "foo2": false
         }
         "zzz": 1
       }

Followed by the following exception:

at Assertion.assertEqual (node_modules/chai/lib/chai/core/assertions.js:485:19)
      at Assertion.ctx.(anonymous function) [as equal] (node_modules/chai/lib/chai/utils/addMethod.js:41:25)
      at test/test-prefs.js:189:31
      at tryCatcher (node_modules/bluebird/js/release/util.js:16:23)
      at Promise._settlePromiseFromHandler (node_modules/bluebird/js/release/promise.js:502:31)
      at Promise._settlePromise (node_modules/bluebird/js/release/promise.js:559:18)
      at Promise._settlePromise0 (node_modules/bluebird/js/release/promise.js:604:10)
      at Promise._settlePromises (node_modules/bluebird/js/release/promise.js:683:18)
      at Async._drainQueue (node_modules/bluebird/js/release/async.js:138:16)
      at Async._drainQueues (node_modules/bluebird/js/release/async.js:148:10)
      at Immediate.Async.drainQueues [as _onImmediate] (node_modules/bluebird/js/release/async.js:17:14)

Then the next test will timeout.

I tested this with a fresh repo and fresh npm install in the repo.
Comment 1 Silenio Quarti CLA 2016-04-22 18:24:37 EDT
All tests are passing after this commit:
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=beb94c56abd0671b27d6e49294434780e5510853