Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 491527

Summary: Splash / progress page does not complete / go away
Product: [ECD] Orion Reporter: Michael Rennie <Michael_Rennie>
Component: ClientAssignee: Silenio Quarti <Silenio_Quarti>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: Silenio_Quarti
Version: 12.0   
Target Milestone: ---   
Hardware: PC   
OS: Mac OS X   
Whiteboard:

Description Michael Rennie CLA 2016-04-12 13:06:08 EDT
Over the past few days I have been having to reload the page to get the progress / splash page to complete / go away.

Steps:
1. open a new tab on an Orion edit page (ctrl+click a file link in the navigator)
2. more than half the time, the resulting page will 'hang' on the progress about starting up Orion - no matter how long I wait it nevver completes.
3. reloading the new page will immediately show the editor on the expected file

I'm using Chrome Canary (52.0.2705.0 canary (64-bit)) if it helps any.
Comment 1 Silenio Quarti CLA 2016-04-13 09:38:10 EDT
I cannot reproduce this. Is there any exception in the console? Does any request in the Network tab fails? Do you get an exception if you check "Pause on exception" in the debugger?
Comment 2 Michael Rennie CLA 2016-04-13 10:22:37 EDT
(In reply to Silenio Quarti from comment #1)
> I cannot reproduce this. Is there any exception in the console? Does any
> request in the Network tab fails? Do you get an exception if you check
> "Pause on exception" in the debugger?

There is nothing in the log, and no uncaught exceptions are thrown. I can try to catch it with the debugger the next time it happens.
Comment 3 Silenio Quarti CLA 2016-04-26 12:07:02 EDT
I was able to reproduce this once. It seems that the page finishes loading properly, but the splash screen is not taken down.  This could happen if the splash code is loaded after the page code has been loaded (very unlikely, but possible).  I changed the code to load first the splash screen module and then the page.

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=c6e2160fc48be601d4f52fb37a5aa9ac8b3bf159

Let me know if you still can reproduce it after these changes.
Comment 4 Michael Rennie CLA 2016-04-27 14:19:51 EDT
(In reply to Silenio Quarti from comment #3)
> I was able to reproduce this once. It seems that the page finishes loading
> properly, but the splash screen is not taken down.  This could happen if the
> splash code is loaded after the page code has been loaded (very unlikely,
> but possible).  I changed the code to load first the splash screen module
> and then the page.
> 
> http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/
> ?id=c6e2160fc48be601d4f52fb37a5aa9ac8b3bf159
> 
> Let me know if you still can reproduce it after these changes.

I have not seen it happen at all today (with the fix in). I'll close this fixed and reopen if I see it again.