Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 491526

Summary:	Patch fails to apply due to whitespace
Product:	[ECD] Orion	Reporter:	Michael Rennie <Michael_Rennie>
Component:	Node	Assignee:	Project Inbox <orion.server-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	Silenio_Quarti
Version:	12.0
Target Milestone:	---
Hardware:	PC
OS:	Mac OS X
Whiteboard:

Description Michael Rennie

2016-04-12 12:24:24 EDT

If you grab the patch from https://bugs.eclipse.org/bugs/attachment.cgi?id=260898 it will fail to apply to master. The reason appears to be because of the end whitespace change in the resolver.js file (if you take that change out the patch applies fine).

Comment 1 Silenio Quarti

2016-04-13 10:48:58 EDT

Fixed by

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=e5cdb1b1ed16893e932bd81820a48dea6d1d55e9

Note that the attached patch was badly generated, so it will not apply even after the fix.  New patches with the "\ No newline at end of file" prefix should work from now one.