Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 491470

Summary: Trying to import zip file kills server
Product: [ECD] Orion Reporter: Michael Rennie <Michael_Rennie>
Component: NodeAssignee: Silenio Quarti <Silenio_Quarti>
Status: RESOLVED FIXED QA Contact:
Severity: critical    
Priority: P3 CC: Olivier_Thomann, Silenio_Quarti
Version: 12.0   
Target Milestone: 12.0   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
The zip file to import none

Description Michael Rennie CLA 2016-04-11 16:04:28 EDT
Created attachment 260869 [details]
The zip file to import

Try importing the attached zip file.

The import appears to succeed (but really didn't) and the server will 503.
Comment 1 Silenio Quarti CLA 2016-04-11 16:25:42 EDT
Exception on the server:

events.js:141
      throw er; // Unhandled 'error' event
      ^

Error: invalid signature: 0x80014
    at /Users/silenio/git/org.eclipse.orion.client/modules/orionode/ws/org.eclipse.orion.client/modules/orionode/node_modules/unzip/lib/parse.js:59:13
    at processImmediate [as _immediateCallback] (timers.js:383:17)
Comment 2 Michael Rennie CLA 2016-04-11 16:42:20 EDT
Perhaps we should try using:

https://www.npmjs.com/package/unzip2

instead of unzip. It seems that there is no traction for the problem in unzip, see:

1. https://github.com/EvanOxfeld/node-unzip/issues/73
2. https://github.com/EvanOxfeld/node-unzip/issues/89
Comment 3 Silenio Quarti CLA 2016-04-11 16:49:42 EDT
Thanks Mike for figuring it out.

Fixed
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=427f190b724e7c87bfd9c2b6a8830298ecb80916