Bugzilla – Full Text Bug Listing
| Summary: | Enhancement for Angle (getDeltaCW/CCW and isClockwise) | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Tools] GEF | Reporter: | Colin Sharples <ctg> | ||||||
| Component: | GEF Geometry | Assignee: | Alexander Nyßen <nyssen> | ||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | nyssen | ||||||
| Version: | 0.2.0 | ||||||||
| Target Milestone: | 4.0.0 (Neon) M7 | ||||||||
| Hardware: | PC | ||||||||
| OS: | Windows NT | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
This contribution complies to the Eclipse Foundation Certificate of Origin. Created attachment 260874 [details]
Test cases for Angle.getDeltaCCW, getDeltaCW and isClockwise
Thanks Colin. Could you please confirm that the second patch complies to the Eclipse Foundation Certificate of Origin as well? The testcase patch complies to the Eclipse Foundation Certificate of Origin. I released your patches to origin/master. Thanks for having contributed them. Resolving this as fixed in 4.0.0 M7. |
Created attachment 260832 [details] Patch to add three methods to Angle I propose a minor enhancement to Angle to make it easier to calculate differences between two angles. There would be three methods involved: getDeltaCW(Angle) - returns the difference between this and the supplied Angle in a clockwise direction, as a new Angle getDeltaCCW(Angle) - as above in a counter-clockwise direction isClockwise(Angle) - returns true if the smallest delta to the other Angle is in a clockwise direction from this Angle.