Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 491228

Summary: [Tooling] The protocol customization in model explorer became broken in Neon
Product: [Modeling] Papyrus-rt Reporter: Peter Cigehn <peter.cigehn>
Component: toolAssignee: Remi Schnekenburger <rschnekenburger>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: eposse, give.a.damus, papyrus-bugs, rschnekenburger
Version: 0.7.2   
Target Milestone: ---   
Hardware: PC   
OS: Windows 7   
See Also: https://git.eclipse.org/r/71186
https://git.eclipse.org/c/papyrus-rt/org.eclipse.papyrus-rt.git/commit/?id=1c69a0fcd8a966a3fb5c91d93cb3da3ac7944dfe
Whiteboard:
Bug Depends on:    
Bug Blocks: 491156    
Attachments:
Description Flags
Screen shot showing the broken protocol customization none

Description Peter Cigehn CLA 2016-04-07 07:22:07 EDT
Created attachment 260770 [details]
Screen shot showing the broken protocol customization

After updating to the latest Papyrus-RT build based on the Neon track, the UML-RT protocol customization in the model explorer is now broken.

The <<Protocol>> Collaboration itself is shown twice, including all the internal elements of the protocol.
Comment 1 Remi Schnekenburger CLA 2016-04-20 11:18:48 EDT
That probably comes from the fix for performances improvement described here: 
485539: [Performances - Facet Manager] FacetManager recomputes the
Facets for a given element too many times
https://bugs.eclipse.org/bugs/show_bug.cgi?id=485539


The solution seems to be a facet operation that overrides the visibleReferences.
Comment 2 Peter Cigehn CLA 2016-04-21 04:29:47 EDT
When I verified Bug 491473 I could see another "glitch" that maybe also could be related to the fixes in the Facet Manager. See Bug 491473 Comment 15 related to the duplication of capsule in the browse dialog when selecting the capsule for capsule part.
Comment 3 Eclipse Genie CLA 2016-04-21 16:52:36 EDT
New Gerrit change created: https://git.eclipse.org/r/71186
Comment 5 Remi Schnekenburger CLA 2016-04-22 08:05:14 EDT
Contribution merged, closing bug.
Comment 6 Peter Cigehn CLA 2016-04-22 08:51:37 EDT
Verified in the latest Papyrus-RT build that the protocol customization now works again. The duplication of capsules mentioned in Comment 2 seem to be fixed as well.
Comment 7 Ernesto Posse CLA 2016-04-22 13:22:34 EDT
Are you sure it's fixed? I have just tested it with the latest master and the model explorer is showing a duplicate of the collaboration both as a direct child of the root element and as a child of the container.

The strangest thing is that it shows "UML-RT Protocols" under Loaded Customizations!

This is what I did:

1. Create new Papyrus project
2. Select UML-RT as the DSML
3. [Next] -> Project name = something -> [Next] -> Browse Registered Profiles -> select UML-RT State Machines -> [OK] -> [Finish]
4. Right click RootElement -> UMLRealTime -> Protocol

The result is both the protocol container and collaboration as direct children of RootElement.

I noticed I had not set the Viewpoints Configuration to Deployed through extension point and the Viewpoint selection to UML-RT Modeler/Viewpoint under Preferences->Papyrus->Viewpoint Configuration, but even after doing so, I got the same result.
Comment 8 Christian Damus CLA 2016-04-22 13:27:51 EDT
I'm not seeing any problems with the Model Explorer, and I've even updated to the latest Papyrus nightly build (201604221249) that broke port positioning in a new and wonderful way (see the discussion at https://git.eclipse.org/r/#/c/71190 ).
Comment 9 Ernesto Posse CLA 2016-04-22 14:27:50 EDT
That was it. After updating Papyrus to the nightly the problem goes away indeed.

I'll re-close it.