Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 491076

Summary: [pull up method] A behavior preserving transformation (Pull Up Method Refactoring) is rejected. [Method declared in type has visibility lower than]
Product: [Eclipse Project] JDT Reporter: Melina Mongiovi <melmongiovi>
Component: UIAssignee: JDT-UI-Inbox <jdt-ui-inbox>
Status: CLOSED WONTFIX QA Contact:
Severity: normal    
Priority: P3    
Version: 4.5   
Target Milestone: ---   
Hardware: PC   
OS: Mac OS X   
Whiteboard: stalebug

Description Melina Mongiovi CLA 2016-04-05 07:43:18 EDT
Behavior Preserving Transformation is rejected.

Reproducible: Always

Steps to Reproduce:
1. Create the following classes

package p;
class A {}

class B extends A {
  public void m(){
  }
}
class B1 extends A {
  private void m(){
  }
}


2. Apply the pull up method refactoring to move method m() from class B to class A.

3. The tool does not apply the transformation and warn the following message:
Method 'p.B1.m()' declared in type ‘p.B1' has visibility lower than ‘package', which will result in compile errors if you proceed.

4. However, the following possible resulting program compiles and the transformation preserves the program behavior, which indicates that some refactoring conditions may be overly strong. 

package p;
class A  {
  void m() {
  }
}

class B extends A  {
}

class B1 extends A  {
  void m() {
  }
}
Comment 1 Eclipse Genie CLA 2019-10-26 16:13:29 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.