Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 490712

Summary:	[tern] use Terns API findQueryExpr rather than exporting findExpr ourselves
Product:	[ECD] Orion	Reporter:	Michael Rennie <Michael_Rennie>
Component:	JS Tools	Assignee:	Michael Rennie <Michael_Rennie>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	curtis.windatt.public
Version:	12.0
Target Milestone:	12.0
Hardware:	All
OS:	All
Whiteboard:

Description Michael Rennie

2016-03-30 12:32:27 EDT

For some reason we are exporting findExpr from Tern, when the function is already exported as findQueryExpr (as API).

We should be using the API and remove our own exports.

Comment 1 Michael Rennie

2016-03-30 16:08:50 EDT

Fixed in:

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=2f4c648e77ef89da46f09a1e96489ae02602cc5a

Comment 2 Curtis Windatt

2016-03-30 17:00:14 EDT

Reopening because the calls to findExpr were not updated in the rules so cross file linting no longer works.

Comment 3 Michael Rennie

2016-03-30 17:06:39 EDT

(In reply to Curtis Windatt from comment #2)
> Reopening because the calls to findExpr were not updated in the rules so
> cross file linting no longer works.

Already fixed it in:

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=a00b3c1dc84969334c33aed0b1bc90bf1212dace

missed the file amongst my many other changes. oops.