Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 490629

Summary:

Merge code from AST tern plugin and ASTmanager

Product:

[ECD] Orion

Reporter:

Michael Rennie <Michael_Rennie>

Component:

JS Tools

Assignee:

Olivier Thomann <Olivier_Thomann>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

Version:

12.0

Target Milestone:

12.0

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
Proposed patch	none

Description Michael Rennie

2016-03-29 14:15:06 EDT

Currently the new ATR plugin and the ASTManager use the same code to hook the Acorn parser and add our customizations (OK), the problem is that they are using copies of each others code (not so OK). We should merge the code into one class that both can share - that way when we update parser prefs, etc, both get the changes without multiple edits.

Comment 1 Michael Rennie

2016-03-29 14:15:52 EDT

That should read: "...the new AST plugin..."

Comment 2 Olivier Thomann

2016-03-29 20:44:16 EDT

Created attachment 260618 [details]
Proposed patch

Comment 3 Olivier Thomann

2016-03-29 20:44:40 EDT

Delivered.