Bug 490535

Comment 1 Donat Csikos 2016-11-15 08:32:32 EST

Hi Andreas! Comments below.

(In reply to Andreas Sewe from comment #0)
> A few observations:
> 
> - The File > Import tree item Gradle > Gradle Project would better be called
> "Existing Gradle Project" (cf. "Maven > Existing Maven Project"), as this
> conveys information to the user about a necessary precondition.

Makes sense, I updated the name: https://github.com/eclipse/buildship/commit/72ec883077910dbf2d9755bded58b9698da168ac

> 
> - The Gradle > Gradle Project tree item's description should read "Import a
> Gradle project *from* the local file system" rather than "[...] in the local
> file system", as this lingo matches General > Preferences, Run/Debug >
> Breakpoints, etc. and IMHO also is slightly more precise.


I adjusted the wording on this one too: https://github.com/eclipse/buildship/commit/9e062d9d1fb6e08ed7af590f9a858815b3e399f7

> 
> - The Working Sets group takes up way to much space on the first wizard
> page. (cf. Maven > Existing Maven Projects how to do this more concisely;
> you can also create new working sets there by using a fresh new.)

I have to disagree on this one. The import wizard looks much like the Java project wizard (see attached screenshot) so imho looks ok.

> 
> - The Advanced Options and Gradle Distribution sections could be moved to
> collapsible sections on the first wizard page (again, cf. "Maven > Existing
> Maven Projects")
> 

Although the idea sounds good, I don't see too much added value. There is so much to implement in Buildship, I think this has a low priority for the time being. Nonetheless, I'll create a separate ticket for this and mark it as 'helpwanted'. If somebody provides a pull request, we'll merge it. 


> - The help text "Click the Finish button to finish the wizard [...]" conveys
> *very* little information as that is just the way wizards work.

That's true, i've adjusted the texts: https://github.com/eclipse/buildship/commit/d6e984c3f64d892390406417a94ba130dbfb3ca6

> 
> - That way you would have two pages: One page to configure everything and
> the one (optional) page to review your choices.
> 
> - Improve the checking of inputs in the Gradle distribution section. I can
> enter a "Remote distribution location" of "foo" only to be greeted with an
> error *after* clicking Finish: URI is not absolute.

We could add some validation to the URI, but the Gradle Tooling API defines no restrictions on the specified instance: https://docs.gradle.org/current/javadoc/org/gradle/tooling/GradleConnector.html#useDistribution(java.net.URI)
I'd just leave the URI validation as it is now.

Comment 2 Donat Csikos 2016-11-15 08:37:48 EST

Created attachment 265356 [details]
Screenshots showing Gradle and Java wizards side-by-side

Comment 3 Donat Csikos 2016-11-15 10:11:06 EST

A little clarification regarding the merge of the wizard pages: I meant to say that if somebody is convinced that merging the pages is the way to go and he is willing to implement it, then we'll have conversation on it and we'll eventually merge it.

tl;dr No automatic merging :)

Comment 4 Donat Csikos 2017-01-11 06:12:52 EST

Buildship 2.0.0 was released today.