Bugzilla – Full Text Bug Listing
| Summary: | Orion should show it's version | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Mike Wilson <Mike_Wilson> | ||||||||
| Component: | Client | Assignee: | Curtis Windatt <curtis.windatt.public> | ||||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||||
| Severity: | enhancement | ||||||||||
| Priority: | P2 | CC: | ahunter.eclipse, curtis.windatt.public, Silenio_Quarti, steve_northover | ||||||||
| Version: | unspecified | ||||||||||
| Target Milestone: | 13.0 | ||||||||||
| Hardware: | Other | ||||||||||
| OS: | All | ||||||||||
| Whiteboard: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Mike Wilson
Seems reasonable. We already have the hotkey CTRL+SHIFT+F1 to bring up the about page. We just need a new "About Orion..." menu entry. If we add a menu item that invokes this, it should be something like 'System information'. People expect 'About XXX' to be a small dialog box. Created attachment 260647 [details]
Fix
This patch adds the menu item. However, on WebIDE the user menu is not available and the orion node server (running on orion.eclipse.org) does not make the about page available. In the host it times out and when self hosting the page cannot be found.
SSQ? Shouldn't this just work? We need to add a couple of endpoints in the node server (/about/about.html and /version). And for the WebIDE, we need to find a place to add the menu item entry. How about File->About? Tools->Version or how about on the settings page in the title? Just need it somewhere. Created attachment 264835 [details]
Putting it in the settings status pane
What about the status pane? Only on the settings page.
Created attachment 264836 [details]
Patch to display in status pane wrapped in darklaunch flag
If you like the way this looks I'll put it into master with the darklaunch flag.
The only problem is that when self hosting the version route will 404. This is going to be a problem no matter what solution we take though.
Setting is fine. Let's make it possible to see the version without having to know an end point. Please just fix this very old and obvious problem. We can tweak where it appears later. http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=27c24d247aa87eec4b4d1ac2755e6b25cde86b5e You must set localStorage.darklaunch=true. We cannot access the version endpoint when self hosting and the xhr 404 will show up in the console. Seems fine. SSQ? (In reply to Steve Northover from comment #13) > Seems fine. SSQ? Sure. go ahead. Note that the version is gone as soon as a command changes the status (i.e. Reload All in plugins page) That's a bug. Are there other places that assume the empty string should be restored? Can we release this and address the bug later (or now if the change is easy)? http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=706a98effaa94545588fed3c0ecab089a0287753 Fixed in master Removed the dark launch flag If the user switches categories the version string will be added back. So in Silenio's example, you see the verison, run reload all plugins, version is gone, click on any category, version string is back. I didn't see a way to have a default status message and there are very few commands on the settings page that affect it. |