Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 490330

Summary: [quickfix] Quick fix all has incorrect selection after running
Product: [ECD] Orion Reporter: Curtis Windatt <curtis.windatt.public>
Component: JS ToolsAssignee: Michael Rennie <Michael_Rennie>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: Michael_Rennie
Version: 12.0   
Target Milestone: 12.0   
Hardware: PC   
OS: Windows 7   
Whiteboard:

Description Curtis Windatt CLA 2016-03-23 15:12:49 EDT 
var a = 'a';
var b = 'b';
var c = 'c';

With missing-nls set to warning, hover over the second string 'b'.  Run quick fix all.  The caret will be set to the //$NON-NLS-1$ for 'a'.  It should select the fix for 'b'.

This is because of a bad comparison in the quick fix all code.  We should be comparing the annotation start/end against each fixed annotation start/end.  Instead we are comparing against the fix start/end.  Fixes don't always match up with the annotation.
Comment 1 Michael Rennie CLA 2016-03-24 11:27:11 EDT 
Fixed in:

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=0ce9febbac2699e44fc2b4ad8cad48c1c7f9fcbc

Also removed unused functions from quickFixes.js