Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 490185

Summary:	Reveal interacted-with parts from the interaction policies.
Product:	[Tools] GEF	Reporter:	Matthias Wienand <matthias.wienand>
Component:	GEF MVC	Assignee:	gef-inbox <gef-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	nyssen
Version:	0.2.0
Target Milestone:	5.0.0 (Oxygen) M2
Hardware:	All
OS:	All
Whiteboard:

Description Matthias Wienand

2016-03-22 09:53:57 EDT

Revealing parts during user interaction should be done from within the interaction policies and not from the underlying transaction policies.

Comment 1 Alexander Nyßen

2016-05-27 10:01:41 EDT

I pushed the following change to origin/master (for 4.0.0 RC3):
- Changed visibility of getRevealOperation() to private, so we can move it to an interaction policy in the next release without breaking the API.

Comment 2 Matthias Wienand

2016-08-04 04:21:47 EDT

Per default, parts are also revealed when they are selected. This is done in the SelectionBehavior. Coupling revealing and selection feedback & handles makes it difficult to change only one of those aspects. Therefore, we should provide another RevealHostOnSelectionBehavior that reveals parts when they are selected and can be registered individually for each part.

Comment 3 Matthias Wienand

2016-09-09 12:19:50 EDT

Pushed the following changes to master:
 - Remove revealing of parts from FXFocusTraversalPolicy and from FXResizeConnectionPolicy.
 - Remove revealing of primary selection from SelectionBehavior.
 - Add revealing of focus part to FXTraverseFocusOnTypePolicy.
 - Add RevealPrimarySelectionBehavior and add a corresponding binding to MvcFxModule.

Therefore, revealing of parts is now done from within the interaction policies, instead of the underlying transaction policies. Regarding revealing of selection, I decided to register only one RevealPrimarySelectionBehavior at the root part that can be exchanged if needed. Thus, I resolve this ticket as fixed for 5.0.0 M2.