Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 490164

Summary: Give better feedback on unsuccesful session opening
Product: [Modeling] Sirius Reporter: Esteban DUGUEPEROUX <esteban.dugueperoux>
Component: CoreAssignee: Esteban DUGUEPEROUX <esteban.dugueperoux>
Status: CLOSED FIXED QA Contact: Florian Barbin <florian.barbin>
Severity: normal    
Priority: P3 CC: florian.barbin, laurent.redor, pierre-charles.david, steve.monnier
Version: 3.1.0Keywords: triaged
Target Milestone: 4.0.0M7   
Hardware: PC   
OS: Linux   
See Also: https://git.eclipse.org/r/68996
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=2acb5761b8e4fffc836e0f21354438c3608f3bd6
https://git.eclipse.org/r/70237
https://git.eclipse.org/c/ecoretools/org.eclipse.ecoretools.git/commit/?id=0ef6f91fa10f2aedc3c2f9bd2806400a76aaf59f
Whiteboard:
Attachments:
Description Flags
Sample throwing a RuntimeException at session opening none

Description Esteban DUGUEPEROUX CLA 2016-03-22 06:01:50 EDT 
When trying to open a session and this last fail, we only have feedback in error log, but if this last is not opened end user has not feedback.
This bugzilla is to give feedback about the cause of an unsuccesful session opening.

Scenario to reproduce:

1. Import plugin from Bug 485837 into your Eclipse, modify it to have SecurityException throwed synchronously to interrupt session opening.
2. Launch a runtime and try to open a Modeling Project => KO we have exception only displayed in error log while we could have ErrorDialog display the cause of the failing session opening.
Comment 1 Eclipse Genie CLA 2016-03-22 06:27:13 EDT 
New Gerrit change created: https://git.eclipse.org/r/68996
Comment 2 Steve Monnier CLA 2016-03-25 11:19:58 EDT 
Created attachment 260579 [details]
Sample throwing a RuntimeException at session opening

I added a plug-in sample that throws a RuntimeException on session opening. As a result when the user opens a session, a popup is opened warning about the opening failure. However, the message contained in the exception (and explaining what happened) is not displayed.
Comment 3 Esteban DUGUEPEROUX CLA 2016-03-29 04:43:14 EDT 
In case of SecurityException or LockInstanceException, 2 popups will appears to show the same session opening issue :

1. a ErrorDialog from Eclipse Platform
2. a MessageDialog from Sirius itself (see LogThroughActiveDialectEditorLogListener).

This will remains a known issue.
Comment 5 Eclipse Genie CLA 2016-04-08 09:14:47 EDT 
New Gerrit change created: https://git.eclipse.org/r/70237
Comment 7 Florian Barbin CLA 2016-05-25 11:19:31 EDT 
Verified on Sirius 4.0.0.RC1
Comment 8 Pierre-Charles David CLA 2016-06-24 08:01:54 EDT 
Available in Sirius 4.0.0.