Bugzilla – Full Text Bug Listing
| Summary: | DOT: use platform specific line separators | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Tools] GEF | Reporter: | Tamas Miklossy <miklossy> | ||||
| Component: | GEF DOT | Assignee: | Alexander Nyßen <nyssen> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | nyssen | ||||
| Version: | unspecified | ||||||
| Target Milestone: | 4.0.0 (Neon) M7 | ||||||
| Hardware: | PC | ||||||
| OS: | Windows 7 | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
Created attachment 260459 [details] Implementation improvement to use platform-specific line separators I uploaded a patch with the following changes (now the test cases succeed again on Windows platform): - Use the platform specific line separators instead of the hard-coded linux-style line separator. - Use the public static String DotFileUtils.read(final File file) method everywhere consistently to read .dot files. Hereby I confirm that my contribution complies with https://www.eclipse.org/legal/CoO.php. Thanks Tamas. I applied your patch, adjusting only the copyright notices. Resolving as fixed in 4.0.0 M7. |
Hello Alexander, Currently the following test cases defined in the DotExportTests.java are failing on Windows platform: - simpleGraph - directedGraph - styledGraph - labeledGraph Within the test cases assertions, the expected strings are concatenated with the platform specific line separators, while the actual strings are concatenated with the hard-coded linux-style line separators. It seems that your new Xtend-based DotExport implementation (Bug 489774) uses platform specific line separators which is not compatible how the test cases are currently implemented.