Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 490043

Summary: shell page won't load in Chrome v49 - Uncaught TypeError: Proxy.create is not a function
Product: [ECD] Orion Reporter: Rafael Chaves <rafael>
Component: ClientAssignee: Mark Macdonald <mamacdon>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: mamacdon, steve_northover
Version: unspecified   
Target Milestone: 12.0   
Hardware: PC   
OS: Linux   
Whiteboard:

Description Rafael Chaves CLA 2016-03-20 21:27:18 EDT
Shell page apparently is broken by Chrome 0.49:

shellPage.js.src.js:24932 Uncaught TypeError: Proxy.create is not a function
...

Reproduced on Linux, against OrionHub.

Related/same issue:

https://productforums.google.com/forum/#!topic/sites/b0NLylR-sqc;context-place=forum/sites
Comment 1 Mark Macdonald CLA 2016-03-21 10:41:00 EDT
The failing code is in org.eclipse.orion.client.ui\web\gcli\util\l10n.js:

> exports.propertyLookup = Proxy.create({
                                 ^^^^^^
Comment 2 Steve Northover CLA 2016-03-21 13:31:33 EDT
Mark, is there a way by this.  The thing is undefined so we could check for it but could the code continue and do something useful?  (didn't look into it)
Comment 3 Rafael Chaves CLA 2016-03-21 13:51:01 EDT
Apparently that provisional API was removed and replaced by a standardized Proxy object, which seems to use a vanilla constructor (note args were swapped):

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Deprecated_and_obsolete_features#Proxy

https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Global_Objects/Proxy#Basic_example
Comment 4 Mark Macdonald CLA 2016-03-21 15:35:42 EDT
Thanks Rafael -- I've patched the offending source to work around the problem.

This is 3rd party code, and patching is not where we want to be. We should open a CQ for a newer version of GCLI.