Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 489975

Summary:	Settings page 'JavaScript Validation' needs to start with sections minimized and remember the last expanded state
Product:	[ECD] Orion	Reporter:	Steve Northover <steve_northover>
Component:	Client	Assignee:	Curtis Windatt <curtis.windatt.public>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P2	CC:	curtis.windatt.public, Michael_Rennie, Silenio_Quarti
Version:	12.0
Target Milestone:	12.0
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Steve Northover

2016-03-18 17:00:55 EDT

Using the expand and collapse is annoying because the state is not remembered when you come back to the page.  Further, you don't even know that the expand/collapse is there because it is expanded by default.  If you scroll too fast and/or don't pay attention, you scroll by the heading and don't see the 'Restore Default' or worse, you think the 'Restore Default' at the top applies to everything.

We can fix this by remembering the expand/collapse state (and starting collapsed) or getting rid of the categories all together.  It's probably best to keep the categories.

Comment 1 Steve Northover

2016-03-18 17:02:02 EDT

Libing, Silenio did work to remember the editor state so likely this page can use the same mechanism.  Perhaps it would be better to get SSQ to implement this?  Your call.

Comment 2 Steve Northover

2016-03-18 17:03:06 EDT

Mike, do you and Curtis own this page?

Comment 3 Curtis Windatt

2016-03-21 10:39:09 EDT

I've done work on the generated settings pages (JS Validation, etc.).  The collapse/expand behaviour is part of the generated pages, and I don't see any custom settings pages that have it.  I don't know who would 'own' the page generation code.

Comment 4 Steve Northover

2016-03-21 12:10:12 EDT

If you ever try and use the feature, this is a huge UI blooper.

Comment 5 Steve Northover

2016-03-21 13:26:35 EDT

I spoke to Libing and he's not the guy.  Silenio implemented a bunch of code that saved state on a page.

Curtis, did you want to take a crack at fixing this?  Talk to SSQ first and see whether that makes sense.  The current behavior is really annoying.

The other thing we could do is just get rid of the collapsible sections (but they are nice if they could remember where you were).

Comment 6 Curtis Windatt

2016-03-21 13:51:49 EDT

FYI, a while back I did experiment with collapsed sections on open.  It was really annoying.  Expand first section, minimize the rest was better.  A third option that I didn't implement was expanding one section collapses the other.

Comment 7 Steve Northover

2016-03-21 16:50:09 EDT

The real answer is to remember.  Collapsing all the time is wrong (but collapsing initially and remembering is fine).

Comment 8 Curtis Windatt

2016-03-22 15:41:36 EDT

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=b62a8ab61838079ad17b321c0a867afaabda9236
All collapsed by default
Remembers any section that you have collapsed.
Only affects plugin contributed settings pages with multiple sections (so only Javascript Validation).

I do not find the collapse all by default behaviour as annoying as I did previously.  Probably because it remembers as I switch between sections.