Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 489793

Summary:	DotInterpreter does not correctly handle name vs. ID
Product:	[Tools] GEF	Reporter:	Alexander Nyßen <nyssen>
Component:	GEF DOT	Assignee:	Alexander Nyßen <nyssen>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3
Version:	0.2.0
Target Milestone:	4.0.0 (Neon) M6
Hardware:	All
OS:	All
Whiteboard:

Description Alexander Nyßen

2016-03-16 16:48:47 EDT

The DOTInterpreter uses the Graph and Node names as their id, which is invalid (because it conflicts with the optional id attribute). We need to ensure that name and id are properly separated and that labels properly falls back to one or other if this is specified in the input.

Comment 1 Alexander Nyßen

2016-03-16 16:54:16 EDT

I pushed the following changes to origin/master:

- Ensured that graph, node, and edge names are properly inferred by the interpreter. 
- Ensured that graph, node, and edge id are properly handled as well.
- Refactored DotAttributes to only use a single constant to define the respective attribute key. Used a respective '__GNE', '__G', '__NE' etc. suffix to indicate to which elements the attribute applies. Ensured that keys of attributes that do not refer to dot attributes, but to build-in properties (name, graph type, etc.) are marked by a '_' prefix, as in '_NAME__GNE', which is inferred from the ID value of the respective graph, or node_id grammar rule (or computed for edges).

Resolving as fixed in 4.0.0 M6.