Bugzilla – Full Text Bug Listing
| Summary: | [Sync] Declare correct lower bound for HttpClient | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Tools] Oomph | Reporter: | Carsten Reckord <reckord> | ||||
| Component: | Utilities | Assignee: | Ed Merks <Ed.Merks> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | Ed.Merks | ||||
| Version: | 1.16.0 | ||||||
| Target Milestone: | --- | ||||||
| Hardware: | PC | ||||||
| OS: | Windows 7 | ||||||
| See Also: | https://git.eclipse.org/r/68495 | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
Actually, it even uses HTTPClient API introduced in 4.3. And additionally, the org.eclipse.core.runtime and org.eclipse.ui bounds are wrong as well. Created attachment 260324 [details]
git patch for proper version bounds
I have a fix prepared, but it looks like the USS repo is not set up for gerrit. So I'll just attach the patch here, like in the good ol' days ;)
New Gerrit change created: https://git.eclipse.org/r/68495 The Gerrit change contains a fix for org.eclipse.oomph.setup.sync, which consumes USS and also uses httpclient directly through api introduced in 4.2. Moving all unresolved bugs to version 1.5.0. I've moved the USS part of this to the USSSDK project: https://bugs.eclipse.org/bugs/show_bug.cgi?id=511332 The wrong lower bound in org.eclipse.oomph.setup.sync remains, so I'll leave this open as well. The fix is committed to master: https://git.eclipse.org/c/oomph/org.eclipse.oomph.git/commit/?id=2804bd66c6fc8c984819be771efadf898b31955e |
USS uses the APache HTTPClient fluent API, which is available since HTTPClient 4.2. But the declared lower bundle-version bound is 4.0: > org.apache.httpcomponents.httpclient;bundle-version="[4.0.0,5.0.0)" This should be updated to 4.2 to reflect the actual requirement.