Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 489385

Summary:

[GTK3] Tree/Table#computeSize(..) returns too small minimal height

Product:

[Eclipse Project] Platform

Reporter:

Markus Keller <markus.kell.r>

Component:

SWT

Assignee:

Markus Keller <markus.kell.r>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

ericwill, markus.kell.r

Version:

4.6

Target Milestone:

4.6 M6

Hardware:

OS:

Linux

See Also:

https://bugs.eclipse.org/bugs/show_bug.cgi?id=531561

Whiteboard:

Attachments:

Description	Flags
Modified Snippet38 (requires JFace)	none

Description Markus Keller

2016-03-10 15:56:50 EST

Created attachment 260235 [details]
Modified Snippet38 (requires JFace)

Steps in I20160308-0800 with EGit from http://download.eclipse.org/egit/updates-nightly (4.3.0.201603022235):

- Select multiple repositories in the Git Repositories view and then choose context menu > Pull.
=> "Pull Result for Multiple Repositories" dialog is not tall enough. It only shows the table headers, but not the content lines.

The bug is that Table#computeSize(..) returns a too small minimal height. Calling TableColumn#pack() seems to work around the bug, that's why it's not reproducible in the ControlExample. The attached snippet reproduces the problem using JFace's TableColumnLayout.

Table#computeSize(..) already contains a hack for bug 432115, but this doesn't work here, because the table has headers.

Comment 1 Eric Williams

2016-03-10 15:57:48 EST

Could this be a duplicate of bug 465056?

Comment 2 Markus Keller

2016-03-10 16:13:01 EST

Fixed with http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=2dab66a2b87bd6aadc5f1bd623db1b5aed609dd4

(In reply to Eric Williams from comment #1)
> Could this be a duplicate of bug 465056?

Not a dup, but it sounds like bug 465056 could have the same underlying reason (wrong size reported by GTK3 APIs).