Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 489294

Summary:	When using a Sirius-defined properties view, it should be possible to disable/hide legacy tabs
Product:	[Modeling] Sirius	Reporter:	Pierre-Charles David <pierre-charles.david>
Component:	Properties	Assignee:	Melanie Bats <melanie.bats>
Status:	CLOSED FIXED	QA Contact:	Julien Dupont <julien.dupont>
Severity:	normal
Priority:	P3	CC:	julien.dupont, stephane.begaudeau, steve.monnier
Version:	3.1.0	Keywords:	triaged
Target Milestone:	4.1.0
Hardware:	All
OS:	All
URL:	https://tuleap.eclipse.org/plugins/tracker/?aid=509
See Also:	https://git.eclipse.org/r/77697 https://git.eclipse.org/c/eef/org.eclipse.eef.git/commit/?id=df41562b4ae396221c11a64d568d1e7636385a52
Whiteboard:	needtest
Bug Depends on:
Bug Blocks:	495366

Description Pierre-Charles David

2016-03-09 10:21:32 EST

By default if the plug-in which implements legacy tabs integration is installed (org.eclipse.eef.properties.ui.legacy), all registered legacy tabs will be shown in addition to the ones explicitly defined/configured from Sirius. It should be possible for specifiers to hide them, either all legacy tabs or some specific ones (typically if the ones they supply are designed to replace old ones).

Comment 1 Eclipse Genie

2016-07-21 11:32:19 EDT

New Gerrit change created: https://git.eclipse.org/r/77697

Comment 2 Eclipse Genie

2016-08-22 08:45:23 EDT

Gerrit change https://git.eclipse.org/r/77697 was merged to [master].
Commit: http://git.eclipse.org/c/eef/org.eclipse.eef.git/commit/?id=df41562b4ae396221c11a64d568d1e7636385a52

Comment 3 Pierre-Charles David

2016-08-25 07:23:47 EDT

So, with the patch above, it is now technically possible to hide legacy tabs. However this requires writing an extension point with some Java code.

Maybe org.eclipse.siruis.ui.properties should provide an implementation of this extension point, driven by the VSM. The specifier could configure his view/pages to indicate they hide/override legacy tabs depending on their category and/or id.

Comment 4 Pierre-Charles David

2016-09-29 05:32:21 EDT

I believe this was fixed by https://git.eclipse.org/r/#/c/81888/, which was associated to bug #496058 instead of this one.

Comment 5 Pierre-Charles David

2016-10-04 09:48:20 EDT

Fixed, see the new Sirius > Sirius Properties View preference page to control this.

Comment 6 Julien Dupont

2016-10-05 04:52:11 EDT

Could you add to this issue the reproducible use case to validate this.

Comment 7 Pierre-Charles David

2016-10-06 08:29:30 EDT

There is no particular test case. Steps to validate:

1. Open a session.
2. Expand the semantic model in the model explorer and select a semantic element.
3. In the properties view you should have both the generated tabs (either the ones you defined in your VSM or the ones produced by the default rules), *and* a tab named "Default".
4. Go to "Preferences > Sirius > Sirius Properties View" and un-check "Show Default tab".
5. Repeat step 3, the "Default" tab should not be visible anymore (but the others should still be).

Same logic with the "Semantic" tab, except that this one appears when you select and element from a Sirius editor instead of from the Model Explorer, and that it has a separate preference (on the same page) to control its own visibility.

Comment 8 Steve Monnier

2016-10-06 10:13:13 EDT

Validated. Note that on step 5, the selection must be changed or the properties view will not be refreshed and therefore still displays the tab that should be hidden.

Comment 9 Pierre-Charles David

2016-10-18 11:07:08 EDT

Available in Sirius 4.1.0, see https://wiki.eclipse.org/Sirius/4.1.0 for details.