Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 489219

Summary: Problem inserting custom donations with AZERTY/DVORAK keyboard
Product: Community Reporter: Eric Poirier <eric.poirier>
Component: WebsiteAssignee: Eric Poirier <eric.poirier>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P2 CC: chris.guindon, victor
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Mac OS X   
Whiteboard:

Description Eric Poirier CLA 2016-03-08 09:31:38 EST
This bug is to keep track of the conversation I had with Victor about a problem when adding custom amount of donation with AZERTY/DVORAK keyboard.


Hi,

On this page:
https://eclipse.org/donate/
With the latest Firefox and Chromium without any plugins.
When trying to enter custom donation amount.
The field stays empty.
The highlighted donation preset is deselected.
The Total amount field becomes empty.

Can you reproduce this?

Cheers,

-- 
Victor/tuxayo

---------------------------------------------------

Hi Victor,

I tried reproducing this without success. I used latest Firefox, Chrome and Chrome Canary.

When disabling Javascript, the custom field stopped working but the predefined amount (35$) stay selected.

Can you tell me more about what you're doing to get  to this result?

Thanks.

Eric Poirier

---------------------------------------------------

I got it.
Try setting a keyboard layout that doesn't have the number directly accessible on the top row.
Example: AZERTY and programmer-DVORAK require to press shift to access the numbers.

I can enter the special characters that are on the top row, but not the letters on the main rows of the keyboard.
It only accepts the characters on the top row when not pressing shift.

Why is the behavior of this field so low level?

-- 
Victor Grousset
Comment 1 Christopher Guindon CLA 2016-03-09 21:22:04 EST
We are currently validating the donation amount each time the user types something in the amount field.

I propose we validate the amount when the user submit the donation form instead. 

We should be use the bootstrapvalidator plugin since it's included with solstice to do this.
Comment 2 Eric Poirier CLA 2016-11-18 15:07:06 EST
I did some testing and this is not an issue anymore.

A patch has been merged a while ago to update how the donation field validates the characters entered. We used to have a JS script to validate that the characters entered were numbers but now we only rely on the number field type (Example: <input type="number">).

So far we haven't had any issues with the donation form since this patch.

I'm closing this bug, but please reopen if the issue is still happening for AZERTY/DVORAK keyboard.

Thanks.
Comment 3 Victor G. CLA 2016-11-21 02:26:59 EST
> I did some testing and this is not an issue anymore.

Confirmed, thanks!