Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 489185

Summary:	Problem with centered edges and specific layout action
Product:	[Modeling] Sirius	Reporter:	Laurent Redor <laurent.redor>
Component:	Diagram	Assignee:	Laurent Redor <laurent.redor>
Status:	CLOSED FIXED	QA Contact:	Florian Barbin <florian.barbin>
Severity:	normal
Priority:	P3	CC:	florian.barbin, pierre-charles.david
Version:	3.1.0	Keywords:	triaged
Target Milestone:	3.1.5
Hardware:	All
OS:	All
See Also:	https://git.eclipse.org/r/67948 https://git.eclipse.org/r/68191 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=cfd5e586242261e01432bc375706acb03dd97514 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=9ff9248fafe1605247cdf8ac467032aa68889988
Whiteboard:
Bug Depends on:
Bug Blocks:	489198

Description Laurent Redor

2016-03-08 03:33:03 EST

Specific layout action can be "broke" by the EdgeLayoutUpdaterModelChangeTrigger.

A test has been added to reveal this problem. In this test, the layout action aligns 2 classes and flattens an edge between them. The result after the action execution is that the edge is not "straight" but has 5 segments. This is not the expected result.

Comment 1 Eclipse Genie

2016-03-08 03:35:48 EST

New Gerrit change created: https://git.eclipse.org/r/67948

Comment 2 Laurent Redor

2016-03-11 03:47:55 EST

Another test has been added: vertical layout with target in auto-size --> there is a desynchronization between draw2d and GMF points.

Comment 3 Eclipse Genie

2016-03-11 03:49:26 EST

New Gerrit change created: https://git.eclipse.org/r/68191

Comment 4 Laurent Redor

2016-03-11 03:55:53 EST

The gerrit https://git.eclipse.org/r/68191 fixes the problem by ignoring the command of EdgeLayoutUpdaterModelChangeTrigger if we consider that the detected notifications correspond to a specific layout: move an edge and at least its source or its target.

Comment 5 Eclipse Genie

2016-03-15 03:50:29 EDT

Gerrit change https://git.eclipse.org/r/67948 was merged to [v3.1.x].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=cfd5e586242261e01432bc375706acb03dd97514

Comment 6 Eclipse Genie

2016-03-15 03:50:31 EDT

Gerrit change https://git.eclipse.org/r/68191 was merged to [v3.1.x].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=9ff9248fafe1605247cdf8ac467032aa68889988

Comment 7 Florian Barbin

2016-04-14 04:53:17 EDT

Verified on Sirius 3.1.5.201604131342

Comment 8 Maxime Porhel

2016-04-21 08:45:36 EDT

Available in Sirius 3.1.5.