Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 489183

Summary:	Regression on centered edges since modification on SessionEventBrokerImpl
Product:	[Modeling] Sirius	Reporter:	Laurent Redor <laurent.redor>
Component:	Diagram	Assignee:	Laurent Redor <laurent.redor>
Status:	CLOSED FIXED	QA Contact:	Florian Barbin <florian.barbin>
Severity:	normal
Priority:	P3	CC:	florian.barbin, pierre-charles.david
Version:	3.1.0	Keywords:	triaged
Target Milestone:	3.1.5
Hardware:	All
OS:	All
See Also:	https://git.eclipse.org/r/67947 https://git.eclipse.org/r/67946 https://git.eclipse.org/r/68190 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=5506f592d5b688a996c611fe3b44107d329cd7f2 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=5831f2366a888270b3197bfbf78e1e67212183d4 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=3bbe6132bb525e572a9064fa78de2a35f85f05e2
Whiteboard:
Bug Depends on:
Bug Blocks:	489199

Description Laurent Redor

2016-03-08 03:11:33 EST

Comment 1 Laurent Redor

2016-03-08 03:23:52 EST

For the bug 428545, the SessionEventBrokerImpl has been changed (commit [1]): the command of all ModelChangeTrigger are created and then executed. Before this change, the command of each ModelChangeTrigger are executed as soon as they are created.

The EdgeLayoutUpdaterModelChangeTrigger has been adapted in commit [1] and then in commit [2] to match with this new behavior.
Since the commit [2], EdgeLayoutUpdaterModelChangeTrigger wrongly handles their notifications.

[1] http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=c8b5274d3ea9459870ce652e15bcd8e359858d7d
[2] http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=e03deaf4d64f55c7a56164ff075e118141c63861

Comment 2 Eclipse Genie

2016-03-08 03:35:50 EST

New Gerrit change created: https://git.eclipse.org/r/67947

Comment 3 Eclipse Genie

2016-03-08 03:35:52 EST

New Gerrit change created: https://git.eclipse.org/r/67946

Comment 4 Laurent Redor

2016-03-11 03:32:26 EST

There are 2 regressions:
* The first when there is only one notification: test testTgtChangingRoutingStyleWithGMFAutoSize() of gerrit [1]
* The second when there several notifications but all are consequences of another one: test testTgtChangingRoutingStyleFromStyleTabWithGMFAutoSize() of gerrit [1]

[1] https://git.eclipse.org/r/#/c/67947/

Comment 5 Eclipse Genie

2016-03-11 03:49:29 EST

New Gerrit change created: https://git.eclipse.org/r/68190

Comment 6 Laurent Redor

2016-03-11 03:52:40 EST

The gerrit https://git.eclipse.org/r/68190 fix the regressions.

Comment 7 Eclipse Genie

2016-03-15 03:50:13 EDT

Gerrit change https://git.eclipse.org/r/67946 was merged to [v3.1.x].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=5506f592d5b688a996c611fe3b44107d329cd7f2

Comment 8 Eclipse Genie

2016-03-15 03:50:27 EDT

Gerrit change https://git.eclipse.org/r/67947 was merged to [v3.1.x].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=5831f2366a888270b3197bfbf78e1e67212183d4

Comment 9 Eclipse Genie

2016-03-15 03:50:28 EDT

Gerrit change https://git.eclipse.org/r/68190 was merged to [v3.1.x].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=3bbe6132bb525e572a9064fa78de2a35f85f05e2

Comment 10 Florian Barbin

2016-04-14 05:21:37 EDT

Verified on Sirius 3.1.5.201604131342

Comment 11 Maxime Porhel

2016-04-21 08:45:26 EDT

Available in Sirius 3.1.5.