Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 488910

Summary:	[HiDpi][GTK] splash screen should show the correct size based on the scaling selected otherwise it gets cropped.
Product:	[Eclipse Project] Equinox	Reporter:	Sravan Kumar Lakkimsetti <sravankumarl>
Component:	Launcher	Assignee:	Sravan Kumar Lakkimsetti <sravankumarl>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	ahmed-gawad, arunkumar.thondapu, clint.eastwool, daniel_megert, eclipse, eclipse, felix.otto, gautier.desaintmartinlacaze, hudsonr, lshanmug, lucag, ma.becker, malaperle, markus.kell.r, michal.zan, mirec.z, niraj.modi, peter, sergejus.sosunovas, shoham5, Silenio_Quarti, sravankumarl, thomas.darimont
Version:	unspecified	Flags:	arunkumar.thondapu: review+
Target Milestone:	Neon M7
Hardware:	All
OS:	Linux
URL:	https://wiki.eclipse.org/High_DPI_open_issues
See Also:	https://git.eclipse.org/r/67708 https://git.eclipse.org/c/equinox/rt.equinox.framework.git/commit/?id=9cb1add9fdf8082b3285309f092be2e2e9679b09
Whiteboard:
Bug Depends on:
Bug Blocks:	479614

Description Sravan Kumar Lakkimsetti

2016-03-02 18:24:06 EST

+++ This bug was initially created as a clone of Bug #399786 +++
Splash screen should scaleup based on the scaling factor selected in the settings

Comment 1 Eclipse Genie

2016-03-02 18:26:45 EST

New Gerrit change created: https://git.eclipse.org/r/67708

Comment 2 Markus Keller

2016-03-17 09:39:48 EDT

The Gerrit duplicates the detection code from Device#getDeviceZoom() into eclipseGtk.c. See bug 489771 for problems with that approach. If this code gets moved into the launcher, then it should be removed from Device#getDeviceZoom().

Comment 3 Sravan Kumar Lakkimsetti

2016-03-18 16:48:14 EDT

(In reply to Markus Keller from comment #2)
> The Gerrit duplicates the detection code from Device#getDeviceZoom() into
> eclipseGtk.c. See bug 489771 for problems with that approach. If this code
> gets moved into the launcher, then it should be removed from
> Device#getDeviceZoom().

The problem here is to dynamic scaling the scaling factor detection code needs to Device#getDeviceZoom()
The splash screen is displayed by the launcher. If there is a way to call swt code from launcher to get scaling-factor, that would fix the duplication issue.

Comment 4 Markus Keller

2016-03-18 20:05:53 EDT

I think the gdk_screen_get_resolution(..) from bug 489771 will replace the big code block, which makes this issue obsolete.

Comment 5 Eclipse Genie

2016-04-21 07:30:55 EDT

Gerrit change https://git.eclipse.org/r/67708 was merged to [master].
Commit: http://git.eclipse.org/c/equinox/rt.equinox.framework.git/commit/?id=9cb1add9fdf8082b3285309f092be2e2e9679b09

Comment 6 Sravan Kumar Lakkimsetti

2016-04-21 08:35:36 EDT

binaries have been recompiled and committed through https://git.eclipse.org/c/equinox/rt.equinox.binaries.git/commit/?id=90e02f5044874dbb5bd2f935d7560f9140786af0

Comment 7 Niraj Modi

2016-04-22 05:59:53 EDT

Spalsh screen looks good now at HighDPI, did a quick verification of this fix in latest N-build(32/64 bit): N20160421-2000

Comment 8 Michal Zan

2017-02-22 04:55:56 EST

Hello, I still see this problem on Ubuntu 16.04 with neon.2 and also neon.1. Could some please verify this? Thanks