Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 488813

Summary: [move method] A behavior preserving transformation (Move Method Refactoring) is rejected because the method to be moved has references to enclosing instances
Product: [Eclipse Project] JDT Reporter: Melina Mongiovi <melmongiovi>
Component: UIAssignee: JDT-UI-Inbox <jdt-ui-inbox>
Status: CLOSED WONTFIX QA Contact:
Severity: normal    
Priority: P3    
Version: 4.5   
Target Milestone: ---   
Hardware: PC   
OS: Mac OS X   
Whiteboard: stalebug

Description Melina Mongiovi CLA 2016-03-01 18:51:27 EST
Behavior Preserving Transformation is rejected.

Reproducible: Always

Steps to Reproduce:
1. Create the following classes

package p1;
import p2.B;
public class A {
  public class Inner {
    public void m( B b){
      System.out.println(A.this);
    }
  }
}

package p2;
public class B {}


2. Apply the move method refactoring to move method m(int) from class B to class C.

3. The tool does not apply the transformation and warn the following message:
The method cannot be moved, since it has references to enclosing instances.

4. Another refactoring tool applies the same transformation and the resulting program (the program below) preserves the program behavior.

package p1;
public class A {
  public class Inner {}
}

package p2;
import p1.A;
import p1.A.Inner;
public class B {
  public void m(Inner inner){
    System.out.println(inner);
  }
}
Comment 1 Eclipse Genie CLA 2020-02-19 20:02:16 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.