Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 488726

Summary: [HTML][assist] Do not include the close tag in assist proposal if we have an existing close tag
Product: [ECD] Orion Reporter: Curtis Windatt <curtis.windatt.public>
Component: JS ToolsAssignee: Curtis Windatt <curtis.windatt.public>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3    
Version: 10.0   
Target Milestone: 12.0   
Hardware: PC   
OS: Windows 7   
Whiteboard:

Description Curtis Windatt CLA 2016-02-29 17:32:45 EST
With the new parser we now know if a tag has a matching end tag.

<style></style>

If you put the caret at the end of style, the proposal will insert the close tag,resulting in 

<style></style>></style>

There are also more complex cases we could try, but since there could be a lot of text inside the tag, the fix has to be very careful about not overwriting anything.
<sty></sty> - Completes the open and modifies the close
<sty></style> - Completes the open and ignores the close
Comment 1 Curtis Windatt CLA 2016-03-01 12:48:20 EST
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=388004d766602f0bbdd51acaa703b18456c5a1f8
Fixed in master with tests (exactly 333 tests in Web Tools)