Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 488520

Summary:	[errors view] clicking on an error removes (x)es from all files
Product:	[ECD] Orion	Reporter:	Steve Northover <steve_northover>
Component:	JS Tools	Assignee:	Michael Rennie <Michael_Rennie>
Status:	RESOLVED FIXED	QA Contact:
Severity:	major
Priority:	P3	CC:	libingw, Olivier_Thomann
Version:	unspecified
Target Milestone:	12.0
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Steve Northover

2016-02-26 01:44:04 EST

1) Get the minesweeper-objects demo
2) Click on main.js (you should see a bunch of (x)s
3) Select minesweeper-objects
4) Run 'Show Problems' from the popup
5) Click on the first error
6) BUG: the error is gone from the file it is in
7) Close the Problems view
8) Click on main.js
9) BUG: all errors are gone
10) Refresh the page
11) All errors are back

Comment 1 libing wang

2016-02-29 18:04:55 EST

Mike, I think it is an AST caching issue but if not please assign it back to me.

Comment 2 Steve Northover

2016-02-29 19:46:35 EST

This behavior is related to the .tern-project file (or lack of it)

These steps work.  Real errors are reported and cross file ones that are fixed by Olivier's code do not come back.  I can get them to come back using other UI actions but let's describe the steps that work:

0) Add this .tern-project file

{
	"libs": ["browser", "ecma5"],
	"loadEagerly": [
		"public/index.html"
	]
}

1) Click on minesweeper-demo (there should be no file being edited)
2) Refresh the browser
3) 'Show Problems ...'
4) Choose an error in 'main.js' (ie. "window is undefined)
5) NO BUG (cross file linting of Counter etc. is working)

IMPORTANT: Click exactly as described above.  If you click on another file first, you might not get a working state.  More investigation needed here.

Comment 3 Steve Northover

2016-02-29 19:55:17 EST

After fixing every single error in the example project, I can get the errors to come back by "clicking around" and then on main.js".  It's worse than cross-file linting not working.  Errors that were fixed by /*eslint-env browser */ come back.

I will work to get definitive steps to make the problem happen every time.

Comment 4 Michael Rennie

2016-03-01 12:41:48 EST

Pushed fix:

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=864c53d0a048df630ef6db1ebbc81abe45910289

It seems that the file content change / AST sync problem coupled with a hack that was put in to hide undef problems in HTML caused errors to be in a bad state. 

With the two fixes, errors are properly showing up for me. Steve, can you try it to confirm?

Comment 5 Steve Northover

2016-03-01 13:46:11 EST

This is working for me.  Thanks for fixing it.  I'll be running through the scenario a bunch of times stressing the code.  Hopefully, comment 3 never happens to me again (I didn't have steps for it anyway).

Comment 6 Michael Rennie

2016-03-03 10:26:21 EST

Thanks for testing. closing as fixed.