Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 488517

Summary: Provide default values for "best tooling experience" (eventually we will make these the new default)
Product: [ECD] Orion Reporter: Steve Northover <steve_northover>
Component: JS ToolsAssignee: Curtis Windatt <curtis.windatt.public>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: curtis.windatt.public, Michael_Rennie
Version: unspecified   
Target Milestone: 12.0   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Attachments:
Description Flags
first page
none
second page
none
third page
none
forth page
none
fifth page
none
sixth page none

Description Steve Northover CLA 2016-02-26 01:14:13 EST
Created attachment 259942 [details]
first page

I am attaching the settings I have (not claiming they are the greatest).  If there is not a table already (I believe there is), let's make one, capture the current default and also the default that we would like for the best tooling experience.  Let's also order the table the same as the preferences.
Comment 1 Steve Northover CLA 2016-02-26 01:14:39 EST
Created attachment 259943 [details]
second page
Comment 2 Steve Northover CLA 2016-02-26 01:14:57 EST
Created attachment 259944 [details]
third page
Comment 3 Steve Northover CLA 2016-02-26 01:15:18 EST
Created attachment 259945 [details]
forth page
Comment 4 Steve Northover CLA 2016-02-26 01:15:36 EST
Created attachment 259946 [details]
fifth page
Comment 5 Steve Northover CLA 2016-02-26 01:15:56 EST
Created attachment 259947 [details]
sixth page
Comment 6 Curtis Windatt CLA 2016-02-29 09:43:21 EST
The first page is editor settings, show occurrences should already be on by default.  Auto show content assist should be on by default if not already.

The rest of the settings (ESLint) are covered under the wiki page
https://wiki.eclipse.org/Orion/ESLint
You can sort the tables there by Setting Message to sort the same as the preference page.

We went through all of these settings in a meeting not too far back and have added quick fixes and updated default severities based on that discussion.  Do you have any idea what changes you would like to see here?

Generally the only change I make from the defaults is to turn on the NLS settings.
Comment 7 Steve Northover CLA 2016-02-29 13:09:25 EST
The only reason I brought this up was that when working on the demo, we'll need to ensure we are all running with the same settings.  We need to be precise about what is turned on and what is not turned on.  That way we will all be testing the same code paths.
Comment 8 Steve Northover CLA 2016-02-29 13:36:43 EST
Please make the wiki page match our preferences one-to-one.  If we have unused or extra rule, add another section "Potential Programming Problems (Unused)" or whatever a good name is.

The goal is to quickly see that the defaults on this page match the code.
Comment 9 Curtis Windatt CLA 2016-02-29 16:42:08 EST
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=1facb9b1dc0f8c22aa8930af800dfe7a2188c0ce
I reordered some of the settings to order them alphabetically.

On the wiki side I moved any unimplemented rules to a separate table and added a comment to remind Steve to sort by setting name to match the ordering in Orion.  Found a few mistakes in severities and links as well.

Reminder to everyone as they update rules and quickfixes to update the wiki page.