Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 488057

Summary:	Update org.eclipse.pde.ua.ui to Java 1.8 to use default methods of IContentProvider
Product:	[Eclipse Project] PDE	Reporter:	Lars Vogel <Lars.Vogel>
Component:	UI	Assignee:	Lars Vogel <Lars.Vogel>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	caniszczyk, daniel_megert, Lars.Vogel, Vikas.Chandra
Version:	4.2
Target Milestone:	4.6 M6
Hardware:	PC
OS:	Linux
See Also:	https://git.eclipse.org/r/66862 https://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=9b8530376bf8cdd5c15f9fbb9279e5d7418a32db https://git.eclipse.org/r/67017 https://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=69f16f0f17aa8eca62bd1e432803dacecf3841ca
Whiteboard:
Bug Depends on:
Bug Blocks:	487943

Description Lars Vogel

2016-02-18 14:56:00 EST

Comment 1 Eclipse Genie

2016-02-18 15:03:23 EST

New Gerrit change created: https://git.eclipse.org/r/66862

Comment 2 Eclipse Genie

2016-02-19 05:01:42 EST

Gerrit change https://git.eclipse.org/r/66862 was merged to [master].
Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=9b8530376bf8cdd5c15f9fbb9279e5d7418a32db

Comment 3 Vikas Chandra

2016-02-20 06:46:44 EST

Reopened to fix this warning too caused by the commit

1. WARNING in /src/org/eclipse/pde/internal/ua/ui/editor/toc/TocHTMLTitleUtil.java
 (at line 53)
FileChannel fc = new FileInputStream(f).getChannel();
Resource leak: '<unassigned Closeable value>' is never closed

http://download.eclipse.org/eclipse/downloads/drops4/N20160219-2000/compilelogs/plugins/org.eclipse.pde.ua.ui_1.1.0.N20160219-2000/@dot.html

Comment 4 Eclipse Genie

2016-02-21 14:47:54 EST

New Gerrit change created: https://git.eclipse.org/r/67017

Comment 5 Eclipse Genie

2016-02-22 01:10:17 EST

Gerrit change https://git.eclipse.org/r/67017 was merged to [master].
Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=69f16f0f17aa8eca62bd1e432803dacecf3841ca

Comment 6 Dani Megert

2016-02-22 06:54:22 EST

(In reply to Eclipse Genie from comment #5)
> Gerrit change https://git.eclipse.org/r/67017 was merged to [master].
> Commit:
> http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=69f16f0f17aa8eca62bd1e432803dacecf3841ca
> 

Thanks, this fixed the warning in the build, but if you set your workspace to report potential leaks as well, then it will show up as warning in the workspace:
Potential resource leak: 'fc' may not be closed

Fixed with http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=dc8075de1a9064e76aa966a63403731a6964843d

Comment 7 Lars Vogel

2016-02-24 04:54:56 EST

*** Bug 244083 has been marked as a duplicate of this bug. ***

Comment 8 Vikas Chandra

2016-03-16 03:05:56 EDT

verified by code inspection