Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 487779

Summary:

[1.9][content assist] jdt.ui support for code completion in module-info

Product:

[Eclipse Project] JDT

Reporter:

Manoj N Palat <manoj.palat>

Component:

Text

Assignee:

Noopur Gupta <noopur_gupta>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

daniel_megert, manoj.palat, noopur_gupta

Version:

4.6

Target Milestone:

BETA J9

Hardware:

All

OS:

All

Whiteboard:

Bug Depends on:

480612

Bug Blocks:

Attachments:

Description	Flags
starter patch	none

Description Manoj N Palat

2016-02-13 00:11:06 EST

This is the jdt ui part of bug 480612

Comment 1 Manoj N Palat

2016-02-24 04:14:14 EST

Created attachment 259895 [details]
starter patch

For bug 486988 to recognize module related enums - a sample patch jdt.ui patch is attached

Comment 2 Noopur Gupta

2016-02-26 04:28:28 EST

Keywords, packages and types completion works as per bug 486988 comment #4 without any extra support from jdt.text.

Completion for module declarations and module references needs support from jdt.core first in terms of CompletionProposals and correct values of replaceStart, replaceEnd etc.

Comment 3 Manoj N Palat

2016-02-28 23:22:52 EST

(In reply to Noopur Gupta from comment #2)
> Keywords, packages and types completion works as per bug 486988 comment #4
> without any extra support from jdt.text.
> 
> Completion for module declarations and module references needs support from
> jdt.core first in terms of CompletionProposals and correct values of
> replaceStart, replaceEnd etc.

Noopur: (1)Did you mean the name for the module when you meant module declaration support? If yes, the code is under test. Let me know if you meant something else. (2) Module reference support is put on hold - in fact it is put under a stub currently which will be implemented after we have better clarification on the model we decide to follow and will not be available immediately.

Comment 4 Noopur Gupta

2016-02-29 02:56:26 EST

(In reply to Manoj Palat from comment #3)
> Noopur: (1)Did you mean the name for the module when you meant module
> declaration support? 
Yes.

>  (2) Module reference support is put on hold
OK.

Comment 5 Noopur Gupta

2016-06-30 09:59:31 EDT

(In reply to Manoj Palat from comment #3)
> (In reply to Noopur Gupta from comment #2)
> > Keywords, packages and types completion works as per bug 486988 comment #4
> > without any extra support from jdt.text.

Manoj, I do not get any keyword proposals now from ICodeAssist#codeComplete in CompletionProposalCollector#accept. Looks like a regression in jdt.core.

Packages and types completion works as expected.

> Noopur: (1)Did you mean the name for the module when you meant module
> declaration support? If yes, the code is under test. 

Yes, please create a separate bug in JDT Text for that once it is implemented in jdt.core.

> (2) Module reference support is put on hold - in fact
> it is put under a stub currently which will be implemented after we have
> better clarification on the model we decide to follow and will not be
> available immediately.

Fixed in jdt.text via bug 495818.

Closing this bug. Separate bugs can be created for any pending support.