Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 487606

Summary:	Detached windows should take UI decorations from parent window
Product:	[Eclipse Project] Platform	Reporter:	Brian de Alwis <bsd>
Component:	UI	Assignee:	Brian de Alwis <bsd>
Status:	VERIFIED FIXED	QA Contact:
Severity:	minor
Priority:	P3	CC:	tom.schindl
Version:	4.2
Target Milestone:	4.6 M7
Hardware:	All
OS:	All
See Also:	https://git.eclipse.org/r/66340 https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=3c96ed5433cf3000b50bef3b9f7dc430838c0a46
Whiteboard:

Description Brian de Alwis

2016-02-10 11:41:39 EST

As pointed out on the forum, detached windows do not have a shell icon and end up using the default images from JFace's Window.getDefaultImages().  We should at least pull the icon from the parent window.

https://www.eclipse.org/forums/index.php?t=rview&goto=1722690#msg_1722690

Comment 1 Eclipse Genie

2016-02-10 14:25:46 EST

New Gerrit change created: https://git.eclipse.org/r/66340

Comment 2 Thomas Schindl

2016-02-10 15:11:39 EST

I added a note on the gerrit-review.

Looking at the resource stuff in general is that we are leaking resources eg. change the image while running we are NOT disposing the image old image :-(

I guess one needs to revisit the resource handling by introducing a ref-counting resource system.

Comment 3 Brian de Alwis

2016-02-10 15:50:58 EST

I considered walking up the parent chain, but that pulls out the perspective icon, which would be disconnected from the parent window.

(In reply to Thomas Schindl from comment #2)
> I added a note on the gerrit-review.

Good point (re: need to monitor iconURI changes on the parent window too).

> Looking at the resource stuff in general is that we are leaking resources
> eg. change the image while running we are NOT disposing the image old image
> :-(

They are disposed of using a #disposeExec registered in SWTPartRenderer#init().  That's effectively a leak for a long-running system.

Comment 4 Eclipse Genie

2016-04-21 13:04:51 EDT

Gerrit change https://git.eclipse.org/r/66340 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=3c96ed5433cf3000b50bef3b9f7dc430838c0a46

Comment 5 Brian de Alwis

2016-04-21 13:06:10 EDT

Fixed for 4.6M7.  Not such a trivial fix after all.

Comment 6 Lars Vogel

2016-04-25 15:10:18 EDT

Mass move to 4.6 RC1. We might push out more to 4.7.

Comment 7 Brian de Alwis

2016-04-25 15:16:40 EDT

Oops, was fixed for M7, but forgot to mark it as resolved.

Comment 8 Brian de Alwis

2016-04-28 10:57:33 EDT

Verified in 4.6.0 I20160427-2000