Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 487532

Summary: Code folding should be disabled when the folding ruler is not showing
Product: [ECD] Orion Reporter: Carolyn MacLeod <Carolyn_MacLeod>
Component: EditorAssignee: Silenio Quarti <Silenio_Quarti>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: snorthov
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Windows 7   
Whiteboard:

Description Carolyn MacLeod CLA 2016-02-09 13:01:52 EST
1) Open a js file that has a block comment (e.g. the initial copyright comment).
2) Click on the (-) icon in the folding ruler to collapse the comment.
3) Right-click on the Settings gear to open the Settings page in a new tab.
4) Click on the Editor Settings category.
5) Scroll down to the Rulers category and uncheck the "Show Folding Ruler" checkbox.
6) Go back to your editor page with the js file in it.

Notice 1) that the comment is still folded,
and 2) that there is no visual indicator that the comment is folded.

Unless the user knows the keystrokes for expanding the folded code (Ctrl+Alt+E or Ctrl+Shift+Alt+E) or they know to type a character into the visible line of the folded comment (which automatically unfolds), they may feel that the editor has deleted some of their code.

Also, at any time, they could type Ctrl+Alt+C or Ctrl+Shift+Alt+C and another section of code would seem to "disappear", with no visual indication that it was simply folded.

So, when the folding ruler is hidden, 2 additional things should happen:
1) anything that was folded should be automatically unfolded
2) the code folding keyboard shortcuts should be completely disabled.
Comment 1 Carolyn MacLeod CLA 2016-02-09 13:03:46 EST
Need to consider whether the string for "Show Folding Ruler" should be changed to something like: "Enable Code Folding" instead.
Comment 2 Carolyn MacLeod CLA 2016-02-09 13:11:41 EST
See also Bug 487527, which is for the CodeEdit standalone editor.