Bugzilla – Full Text Bug Listing
|
Description
Eric Williams
New Gerrit change created: https://git.eclipse.org/r/68046 Gerrit change https://git.eclipse.org/r/68046 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=345697d77606dfd42eba2882f0bc51d11576834e (In reply to Eclipse Genie from comment #2) > Gerrit change https://git.eclipse.org/r/68046 was merged to [master]. > Commit: > http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/ > ?id=345697d77606dfd42eba2882f0bc51d11576834e This updates toolbars and window underpinnings. Waiting for bug 483097 to be merged and then I will update the background/foreground CSS. New Gerrit change created: https://git.eclipse.org/r/69657 Gerrit change https://git.eclipse.org/r/69657 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=b25636194fb9a2fb5329522cd28d1f794bd08d14 (In reply to Eclipse Genie from comment #5) > Gerrit change https://git.eclipse.org/r/69657 was merged to [master]. > Commit: > http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/ > ?id=b25636194fb9a2fb5329522cd28d1f794bd08d14 This patch restores GTK3.18 toolbar sizes for 3.20. New Gerrit change created: https://git.eclipse.org/r/69729 Gerrit change https://git.eclipse.org/r/69729 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=688b4f2113a6b8602f7f40b972a9a1b545b4ffc6 New Gerrit change created: https://git.eclipse.org/r/69832 Gerrit change https://git.eclipse.org/r/69832 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=efa2634e4209791dbdb491ab13cbca55a327fb0a (In reply to Eclipse Genie from comment #10) > Gerrit change https://git.eclipse.org/r/69832 was merged to [master]. > Commit: > http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/ > ?id=efa2634e4209791dbdb491ab13cbca55a327fb0a This patch updates background colors to GTK3.20 style CSS nodes. New Gerrit change created: https://git.eclipse.org/r/69848 Gerrit change https://git.eclipse.org/r/69848 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=3efcb608db7b67648f0faf639e4664e5c54508fb (In reply to Eclipse Genie from comment #13) > Gerrit change https://git.eclipse.org/r/69848 was merged to [master]. > Commit: > http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/ > ?id=3efcb608db7b67648f0faf639e4664e5c54508fb Small typo fix for os_custom.h. New Gerrit change created: https://git.eclipse.org/r/69850 Gerrit change https://git.eclipse.org/r/69850 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=c45c50d4eb0964254583e7a949a66bd46c2c69e8 (In reply to Eclipse Genie from comment #16) > Gerrit change https://git.eclipse.org/r/69850 was merged to [master]. > Commit: > http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/ > ?id=c45c50d4eb0964254583e7a949a66bd46c2c69e8 Final fix is in, all the CSS being fed to GTK is 3.20/CSS node compatible. All these code duplications for GTK >= OS.VERSION(3, 20, 0) are a breeding ground for future errors that will inevitable creep in: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/diff/bundles/org.eclipse.swt/Eclipse%20SWT/gtk/org/eclipse/swt/widgets/Tree.java?id=efa2634e4209791dbdb491ab13cbca55a327fb0a Please replace this with a DRY (don't repeat yourself) coding style that keeps the main CSS in a single place and only branches on the real differences. E.g. like this: String treeview = OS.GTK_VERSION >= OS.VERSION(3, 20, 0) ? "treeview" : "GtkTreeView"; css = treeview + " {background-color: " + display.gtk_rgba_to_css_string(background) + ";}\n"; Or like this, if the mapping is somehow predictable and you can offload the conversion to a utility method adjustCssSelector(..): String css = adjustCssSelector("GtkTreeView") + " {background-color: " + display.gtk_rgba_to_css_string(background) + ";}\n"; (In reply to Markus Keller from comment #18) > All these code duplications for GTK >= OS.VERSION(3, 20, 0) are a breeding > ground for future errors that will inevitable creep in: > > http://git.eclipse.org/c/platform/eclipse.platform.swt.git/diff/bundles/org. > eclipse.swt/Eclipse%20SWT/gtk/org/eclipse/swt/widgets/Tree. > java?id=efa2634e4209791dbdb491ab13cbca55a327fb0a > > Please replace this with a DRY (don't repeat yourself) coding style that > keeps the main CSS in a single place and only branches on the real > differences. > > E.g. like this: > > String treeview = OS.GTK_VERSION >= OS.VERSION(3, 20, 0) ? "treeview" : > "GtkTreeView"; > css = treeview + " {background-color: " + > display.gtk_rgba_to_css_string(background) + ";}\n"; > > Or like this, if the mapping is somehow predictable and you can offload the > conversion to a utility method adjustCssSelector(..): > > String css = adjustCssSelector("GtkTreeView") + " {background-color: " + > display.gtk_rgba_to_css_string(background) + ";}\n"; Yeah that's reasonable, I'll implement something later today. New Gerrit change created: https://git.eclipse.org/r/70643 (In reply to Eclipse Genie from comment #20) > New Gerrit change created: https://git.eclipse.org/r/70643 Markus: I made a change with your suggestions. Please let me know if it looks good to you. Gerrit change https://git.eclipse.org/r/70643 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=84ec0e619bac5a9b2208d8b35fe0fc7d85a0818a Hi Eric, Can you please verify this for M7 milestone build? Thanks Sravan (In reply to Sravan Kumar Lakkimsetti from comment #23) > Hi Eric, > > Can you please verify this for M7 milestone build? > > Thanks > Sravan Verified fixed in N20160423-1500. |