Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 486832

Summary:	Handle feedback for viewer focus and focussed part (in case its not selected).
Product:	[Tools] GEF	Reporter:	Alexander Nyßen <nyssen>
Component:	GEF MVC	Assignee:	gef-inbox <gef-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	matthias.wienand
Version:	0.2.0
Target Milestone:	4.0.0 / 3.11.0 (Neon) M5
Hardware:	All
OS:	All
Whiteboard:

Description Alexander Nyßen

2016-01-29 10:04:16 EST

Currently, focus is only indicated for those parts that are also selected. We need to indicate focus feedback also for those parts that are focussed but not selected, and we need to indicate viewer focus if no explicit focus part is set but the viewer itself has viewer focus. This is the prerequisite to properly support keyboard navigation (bug #481679), which requires a proper feedback indication.

We could either extend the SelectionBehavior to also handle focus changes (renaming it into FocusAndSelectionBehavior), or introduce a FocusBehavior specifically for this purpose. In the latter case, it needs to be ensured that both feedback mechanisms do not interfere when the selected part also has focus.

Comment 1 Matthias Wienand

2016-02-01 13:06:35 EST

I added focus feedback and coordinated it with selection feedback as follows:

 - An FXDefaultFocusFeedbackPartFactory generates the feedback parts.
 - FXFocusFeedbackPart visualizes focus feedback as a blue frame around its host.
 - Selection feedback uses black and grey frames to differentiate primary and secondary selection.
 - Added a gap between the visual and the feedback.
 - Added highlighting viewer focus via a blue frame around the viewer.

The changes are published on the master branch, therefore, I resolve this ticket as fixed for 3.11.0M5.