Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 486555

Summary:	Remove AbstractFXTool and provide ITargetResolver instead.
Product:	[Tools] GEF	Reporter:	Matthias Wienand <matthias.wienand>
Component:	GEF MVC	Assignee:	gef-inbox <gef-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	cletavernier
Version:	0.2.0
Target Milestone:	4.0.0 / 3.11.0 (Neon) M5
Hardware:	All
OS:	All
Whiteboard:

Description Matthias Wienand

2016-01-26 08:00:36 EST

The only responsibility of the AbstraxtFXTool is to determine the target policies for a given JavaFX event. This requires re-implementing all tools if a change to the target determination is desired. To overcome this issue, the AbstractFXTool should be removed and the target determination should be provided to the tools as a strategy. Then, the strategy can be replaced by changing the binding within the module.

Comment 1 Matthias Wienand

2016-01-28 05:47:58 EST

I removed the AbstractFXTool and added an ITargetPolicyResolver interface with a DefaultTargetPolicyResolver implementation that contains the functionality of the old AbstractFXTool. The ITargetPolicyResolver strategy is injected into the individual tool implementations and a binding for the strategy is defined within MvcFxModule. The code is published on the master branch, therefore, I resolve this ticket for 3.11.0M5.