Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 486475

Summary:

Fill action doesn't work correctly for filling cells horizontally

Product:

[Technology] NatTable

Reporter:

Vincent Lorenzo <vincent.lorenzo>

Component:

Core

Assignee:

Dirk Fauth <dirk.fauth>

Status:

CLOSED FIXED

QA Contact:

Severity:

enhancement

Priority:

CC:

dirk.fauth, nifauvergue

Version:

unspecified

Target Milestone:

1.4.0

Hardware:

OS:

Windows 7

See Also:

https://git.eclipse.org/r/65145
https://git.eclipse.org/c/nattable/org.eclipse.nebula.widgets.nattable.git/commit/?id=13d3eefce84e257e4f3e6c84b57e53f354d52320

Whiteboard:

Bug Depends on:

Bug Blocks:

486096

Attachments:

Description	Flags
a video to show the problem	none

Description Vincent Lorenzo

2016-01-25 09:10:57 EST

Tested on NatTable 1.4 : 


Filling cells vertically works fine, but the behavior for horizontally filling seems us differents. If we select 3 cells vertically, the green rectangle used to fill cells horizontally is available only for the selection which have the same number of columns than the number of rows selected in the initial selection. Please see video in attachement for a better understanding.

Comment 1 Vincent Lorenzo

2016-01-25 09:13:07 EST

Created attachment 259364 [details]
a video to show the problem

a video to show the problem

Comment 2 Dirk Fauth

2016-01-25 11:09:19 EST

You can move by one column in that scenario, but you need to move on the first line.

The issue is in FillHandleDragMode where the direction is determined by the first cell in the selection, and not the one to which the fill handle is connected to.

Need to check how this can be fixed. Looks trivial in first place, but several calculations break if I simply update to use the other cell.

Comment 3 Eclipse Genie

2016-01-25 17:00:43 EST

New Gerrit change created: https://git.eclipse.org/r/65145

Comment 4 Eclipse Genie

2016-01-25 17:03:18 EST

Gerrit change https://git.eclipse.org/r/65145 was merged to [master].
Commit: http://git.eclipse.org/c/nattable/org.eclipse.nebula.widgets.nattable.git/commit/?id=13d3eefce84e257e4f3e6c84b57e53f354d52320

Comment 5 Dirk Fauth

2016-01-25 17:09:28 EST

Fixed with applied patch. Please verify with latest snapshot build

Comment 6 Dirk Fauth

2016-06-01 17:09:13 EDT

Released with 1.4.0