Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 486235

Summary:

[GTK3] SWT.TOGGLE buttons rendered like SWT.PUSH buttons in toolbars

Product:

[Eclipse Project] Platform

Reporter:

Andreas Sewe <sewe>

Component:

SWT

Assignee:

Platform-SWT-Inbox <platform-swt-inbox>

Status:

RESOLVED WORKSFORME

QA Contact:

Severity:

major

Priority:

CC:

akurtakov, ericwill

Version:

4.5.1

Keywords:

triaged

Target Milestone:

---

Hardware:

OS:

Linux

Whiteboard:

Attachments:

Description	Flags
Package Explorer with Linked Mode enabled	none
Package Explorer with Linked Mode disabled	none
Package Explorer with Linked Mode enabled (oxygen-gtk theme)	none

Description Andreas Sewe

2016-01-21 05:58:56 EST

Tested with Mars.1 under Kubuntu 15.10:

The various toggle buttons in, e.g., the Package Explorer (Link with Editor) or Mylyn's Tasks view (Categorized, Schedules) are all rendered like push buttons. Toggling leaves no visual indication of the button's toggle state. 

FWIW, this may or may not be related to Bug 403887, as all toolbar toggle buttons I am aware of are flat.

Comment 1 Alexander Kurtakov

2016-01-26 17:16:07 EST

Would you please attach a screenshot of the broken state? 
It looks well for me on Fedora 23. Would you please try different gtk theme?

Comment 2 Andreas Sewe

2016-01-27 04:07:42 EST

Created attachment 259404 [details]
Package Explorer with Linked Mode enabled

(In reply to Alexander Kurtakov from comment #1)
> Would you please attach a screenshot of the broken state? 

I'll attach two screenshots, one with Linked Mode enabled, one with Linked Mode disabled (although there really isn't a visual difference).

Comment 3 Andreas Sewe

2016-01-27 04:08:06 EST

Created attachment 259405 [details]
Package Explorer with Linked Mode disabled

Comment 4 Andreas Sewe

2016-01-27 04:26:37 EST

Created attachment 259406 [details]
Package Explorer with Linked Mode enabled (oxygen-gtk theme)

> It looks well for me on Fedora 23. Would you please try different gtk theme?

According to System Settings > Application Style > GNOME Application Style (GTK), the problematic style is "Orion". I tried other themes:

- "Orion": bug (also exhibits Bug 480243)
- "oxygen-gtk": bug (see screenshot, also exhibits Bug 480243)
- "Emacs": *no* bug (and *no* Bug 480243)
- "Default" (oddly not the default theme of Kubuntu): *no* bug (and *no* Bug 480243)

Hope this helps in narrowing down the problem.

Comment 5 Leo Ufimtsev

2016-09-19 10:28:32 EDT

We should look into this bug, but as per Eclipse wiki, I don't think it quite classifies as 'critical':
https://wiki.eclipse.org/WTP/Conventions_of_bug_priority_and_severity#Severity
Importance: Critical -> Major

Comment 6 Andreas Sewe

2016-09-19 10:45:39 EDT

(In reply to Leo Ufimtsev from comment #5)
> We should look into this bug, but as per Eclipse wiki, I don't think it
> quite classifies as 'critical':
> https://wiki.eclipse.org/WTP/
> Conventions_of_bug_priority_and_severity#Severity

Thanks for the pointer, Leo. I wasn't aware that WTP had done such a nice write-up of severities. 

> Importance: Critical -> Major

While Platform != WTP, this seems like a fair assessment.

Comment 7 Eric Williams

2018-06-29 15:50:39 EDT

I can't reproduce this issue on SWT master as of today, GTK3.22, and Fedora 28. This is likely another oxygen-gtk bug which was deprecated long ago.