Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 486176

Summary: Refactoring: Move method missing "this"-qualifier on shadowed fields
Product: [Eclipse Project] JDT Reporter: Anna Eilertsen <anna.eilertsen>
Component: UIAssignee: JDT-UI-Inbox <jdt-ui-inbox>
Status: CLOSED WONTFIX QA Contact:
Severity: normal    
Priority: P3 CC: loskutov, stephan.herrmann
Version: 4.5.1   
Target Milestone: ---   
Hardware: PC   
OS: Linux   
Whiteboard: stalebug

Description Anna Eilertsen CLA 2016-01-20 09:37:28 EST
Executing the move-refactoring such that the resulting method has a local variable shadowing a field in target class leads to missing this-qualifier on the field access. 

Example: 

class A {
    B b;
    void foo(){String s = b.s;}
}

class B{
    String s;
}

Moving foo to B gives us: 

class A {
    B b;
}

class B{
    String s;
    void foo(){String s = s;}
}
Comment 1 Andrey Loskutov CLA 2016-01-20 09:42:53 EST
Please report Java related refactoring issues to the JDT product.
Comment 2 Eclipse Genie CLA 2020-01-05 09:34:10 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.