Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 485566

Summary:	theme import problems
Product:	[ECD] Orion	Reporter:	Grant Gayed <grant_gayed>
Component:	Client	Assignee:	Silenio Quarti <Silenio_Quarti>
Status:	RESOLVED FIXED	QA Contact:
Severity:	major
Priority:	P2	CC:	grant_gayed
Version:	10.0
Target Milestone:	11.0
Hardware:	PC
OS:	All
Whiteboard:

Description Grant Gayed

2016-01-11 11:47:58 EST

Two problems have been recently introduced in this area:

1: After pressing the 'Import' button the dialog that receives the drag does not render its link properly, it just shows as plaintext.

2. After dragging a Sublime theme the import does not complete.

Investigating...

Comment 1 Grant Gayed

2016-01-11 11:49:30 EST

3. A changed theme now gets reverted when the Save button is pressed.

Comment 2 Grant Gayed

2016-01-12 15:42:18 EST

Fixed #1 with commit: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=aff8e7ef49362f4876ffc17b54eb6882ccf661b7 .

Problems #2 and #3 were introduced by the fix for bug 483691.  SSQ would understand these changes best, so reassigning to him.

Comment 3 Silenio Quarti

2016-01-12 16:34:55 EST

(In reply to Grant Gayed from comment #2)
> Problems #2 and #3 were introduced by the fix for bug 483691.  SSQ would
> understand these changes best, so reassigning to him.

#2 is fixed by

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=2248dc14eedd0b19aa5b84b2ce163c5187e27549

Please try number #3 in latest and reopen if needed.

Comment 4 Grant Gayed

2016-01-12 16:55:56 EST

I've verified that #3 is now fixed as well, thanks!