Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 485191

Summary:

GTK theme messed up when overriding Adwaita:dark with Adwaita:light.

Product:

[Eclipse Project] Platform

Reporter:

Pavel Sklenak <pavel.sklenak>

Component:

SWT

Assignee:

Platform-SWT-Inbox <platform-swt-inbox>

Status:

CLOSED WORKSFORME

QA Contact:

Severity:

normal

Priority:

CC:

akurtakov, ericwill, gautier.desaintmartinlacaze

Version:

4.6

Keywords:

triaged

Target Milestone:

---

Hardware:

OS:

Linux

Whiteboard:

Attachments:

Description	Flags
Appearance preferences	none
Screenshot - a camera picture	none
Preferences - selection background color	none
Camera - content assist popup	none
Heap status	none
Text selection color is shown white on gray background	none
Text selection color is shown white on gray background	none
Javadoc view	none

Description Pavel Sklenak

2016-01-05 03:18:13 EST

I am using GTK 3.18 with Adwaita:dark global theme but eclipse with Adwaita:light theme as follows:
Exec=env GTK_THEME=Adwaita:light /home/bin/eclipse-4.6/eclipse

There are several colors that seems to be leaking from the dark theme thus causing the text not being readable.

E.g. when debugging - inspect view - shows white text on (almost) white background. I cannot make screenshot as the popup disappears before taking the screenshot.

Javadoc view - black background, white text.

I would expect the system colors being taken from the light theme.

Comment 1 Pavel Sklenak

2016-01-05 03:19:54 EST

Created attachment 258992 [details]
Appearance preferences

Comment 2 Pavel Sklenak

2016-01-05 03:23:35 EST

Selection color is very light on white background (e.g. console)

Comment 3 Pavel Sklenak

2016-01-06 05:30:11 EST

Created attachment 259018 [details]
Screenshot - a camera picture

Attached a camera picture capturing my screen. Sorry, the window gets closed on taking a regular screenshot.

Comment 4 Pavel Sklenak

2016-01-13 04:07:32 EST

Created attachment 259144 [details]
Preferences - selection background color

User defined selected background color is not respected in e.g. content assist popup

Comment 5 Pavel Sklenak

2016-01-13 04:08:25 EST

Created attachment 259145 [details]
Camera - content assist popup

Comment 6 Pavel Sklenak

2016-01-13 04:12:44 EST

Created attachment 259146 [details]
Heap status

Comment 7 Pavel Sklenak

2016-01-15 05:42:48 EST

Created attachment 259197 [details]
Text selection color is shown white on gray background

Comment 8 Pavel Sklenak

2016-01-15 05:48:24 EST

Created attachment 259198 [details]
Text selection color is shown white on gray background

Comment 9 Alexander Kurtakov

2016-04-15 11:42:41 EDT

Please try with the latest I-build. There were many bugs with regarding fetching system colors with some of the new themes which required us to go through gtk css machinery. All should be fine now (except for Heap status widget which has a bug in it).

Comment 10 Pavel Sklenak

2016-04-18 09:22:23 EDT

Tested with http://download.eclipse.org/eclipse/downloads/drops4/I20160417-1112/

System selection color (background, foreground, line marker) is fixed in both main editor and e.g. console view.

Javadoc & inspect popups use dark theme but at least it is readable.
Javadoc view is newly unreadable. (white text on light gray)

Overall it provides a better experience though there are still some issues left.

Comment 11 Pavel Sklenak

2016-04-18 09:22:57 EDT

Created attachment 261038 [details]
Javadoc view

Comment 12 Pavel Sklenak

2016-04-18 09:28:24 EDT

Context assist is also fixed.

It seems that the popups are the biggest remaining part. I think I read somewhere about a transparency problem with GTK2 -> GTK3, it might be related.

Comment 13 Pavel Sklenak

2016-04-22 04:26:54 EDT

Hovering over task markers and quick fix proposals gives dark gray text on black background (unreadable)

Test code (2 markers):
    if (1 == 1) { 
      System.out.println();
      // TODO ....
    }

Comment 14 Alexander Kurtakov

2018-01-15 16:06:45 EST

Is this still reproducible with Oxygen.

Comment 15 Eric Williams

2018-08-16 11:54:35 EDT

(In reply to Alexander Kurtakov from comment #14)
> Is this still reproducible with Oxygen.

No response in awhile, and I believe this was fixed in 4.8 by adding support for GTK_THEME with dark/light variants. Please reopen this ticket if the bug still happens with 4.8 or even 4.9 M2.