Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 484609

Summary:	load-rules-async.js uses != to compare with null
Product:	[ECD] Orion	Reporter:	Olivier Thomann <Olivier_Thomann>
Component:	JS Tools	Assignee:	Olivier Thomann <Olivier_Thomann>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	curtis.windatt.public
Version:	10.0
Target Milestone:	11.0
Hardware:	PC
OS:	Windows 7
See Also:	https://git.eclipse.org/r/62964 https://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=6bcd0f3bcb522b6f048838fa2361126f17b88222
Whiteboard:

Description Olivier Thomann

2015-12-17 15:00:25 EST

After enabling the new rule for null comparison, I found errors in load-rules-async.js file.

Comment 1 Eclipse Genie

2015-12-17 15:03:27 EST

New Gerrit change created: https://git.eclipse.org/r/62964

Comment 2 Eclipse Genie

2015-12-17 15:07:09 EST

Gerrit change https://git.eclipse.org/r/62964 was merged to [master].
Commit: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=6bcd0f3bcb522b6f048838fa2361126f17b88222

Comment 3 Curtis Windatt

2015-12-17 15:08:19 EST

There is going to be a lot more of these types of fixes with the new rules.  Not everyone is running with missing-nls and unecessary-nls rules turned on yet either.

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=6bcd0f3bcb522b6f048838fa2361126f17b88222
Merged